Check privacy of trait items in all contexts#41332
Merged
bors merged 3 commits intorust-lang:masterfrom Apr 26, 2017
Merged
Conversation
Contributor
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
r? @eddyb |
eddyb
approved these changes
Apr 16, 2017
Member
|
The changes LGTM, started a crater run to see if there's any real impact. |
Mark-Simulacrum
added
the
S-waiting-on-bors
Member
|
Sadly, Crater now outputs |
arielb1
added
S-waiting-on-author
eddyb
added
the
S-waiting-on-crater
Member
|
Paging @brson again, to make sure he sees it when he gets back. |
Member
|
@eddyb Did you try again since? |
Contributor
Contributor
Member
|
@bors r+ |
Collaborator
|
📌 Commit 4f7ab0e has been approved by |
arielb1
added
S-waiting-on-bors
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Apr 25, 2017
Check privacy of trait items in all contexts Fixes rust-lang#28514 This is a sufficiently rare scenario and it's currently guarded by `private_in_public` lint, so it shouldn't be a [breaking-change] in practice.
Collaborator
|
⌛ Testing commit 4f7ab0e with merge c53bc6d... |
Collaborator
|
💔 Test failed - status-travis |
Contributor
Author
|
Conflict with recently merged #41494, will fix today. |
Contributor
|
@bors r- |
Contributor
Author
|
@bors r=eddyb |
Collaborator
|
📌 Commit 4bd417e has been approved by |
Collaborator
|
⌛ Testing commit 4bd417e with merge a268165... |
Collaborator
|
💔 Test failed - status-appveyor |
Member
|
Probably spurious, though odd. Filed #41545 to track this. @bors retry |
Collaborator
bors
added a commit
that referenced
this pull request
Apr 25, 2017
Check privacy of trait items in all contexts Fixes #28514 This is a sufficiently rare scenario and it's currently guarded by `private_in_public` lint, so it shouldn't be a [breaking-change] in practice.
Mark-Simulacrum
removed
the
S-waiting-on-crater
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Dec 21, 2017
Type privacy polishing Various preparations before implementing rust-lang/rfcs#2145 containing final minor breaking changes (mostly for unstable code or code using `allow(private_in_public)`). (Continuation of #42125, #44633 and #41332.) It would be good to run crater on this. r? @eddyb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28514
This is a sufficiently rare scenario and it's currently guarded by
private_in_publiclint, so it shouldn't be a [breaking-change] in practice.