std: Back out backtrace pruning logic#41364
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 18, 2017
Merged
Conversation
It was discovered rust-lang#40264 that this backtrace pruning logic is a little too aggressive, so while we figure how out to handle rust-lang#40264 this commit backs out the changes to prune frames. Note that other cosmetic changes, such as better path printing and such remain.
Contributor
|
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit e46a8bd has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…r=petrochenkov std: Back out backtrace pruning logic It was discovered rust-lang#40264 that this backtrace pruning logic is a little too aggressive, so while we figure how out to handle rust-lang#40264 this commit backs out the changes to prune frames. Note that other cosmetic changes, such as better path printing and such remain.
This was referenced Apr 18, 2017
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…r=petrochenkov std: Back out backtrace pruning logic It was discovered rust-lang#40264 that this backtrace pruning logic is a little too aggressive, so while we figure how out to handle rust-lang#40264 this commit backs out the changes to prune frames. Note that other cosmetic changes, such as better path printing and such remain.
Contributor
|
This might've unintentionally removed the message that shows that you can switch to a full backtrace with "RUST_BACKTRACE=full", because the logic for it checks whether frames got omitted: rust/src/libstd/sys_common/backtrace.rs Line 74 in 9f2abad So this message never shows up. |
Member
Author
|
@CryZe that's somewhat intentional, the |
Contributor
|
Ah okay, thanks for clarifying :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was discovered #40264 that this backtrace pruning logic is a little too
aggressive, so while we figure how out to handle #40264 this commit backs out
the changes to prune frames. Note that other cosmetic changes, such as better
path printing and such remain.