Give a nicer error for non-Unicode arguments to rustc and rustdoc#42092

cuviper · 2017-05-18T23:15:03Z

Previously, any non-Unicode argument would panic rustc:

$ rustc $'foo\x80bar'
error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report:
https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

thread 'rustc' panicked at 'called `Result::unwrap()` on an `Err` value:
"foo�bar"', /checkout/src/libcore/result.rs:859 note: Run with
`RUST_BACKTRACE=1` for a backtrace.

Now it gives a clean error:

$ rustc $'foo\x80bar'
error: Argument 1 is not valid Unicode: "foo�bar"

Maybe fixes #15890, although we still can't compile arbitrary file names.

Previously, any non-Unicode argument would panic rustc: ``` $ rustc $'foo\x80bar' error: internal compiler error: unexpected panic note: the compiler unexpectedly panicked. this is a bug. note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports thread 'rustc' panicked at 'called `Result::unwrap()` on an `Err` value: "foo�bar"', /checkout/src/libcore/result.rs:859 note: Run with `RUST_BACKTRACE=1` for a backtrace. ``` Now it gives a clean error: ``` $ rustc $'foo\x80bar' error: Argument 1 is not valid Unicode: "foo�bar" ``` Maybe fixes rust-lang#15890, although we still can't *compile* arbitrary file names.

rust-highfive · 2017-05-18T23:15:13Z

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

Mark-Simulacrum · 2017-05-18T23:58:46Z

Seems like a clear improvement to me, thanks!

@bors r+

bors · 2017-05-18T23:58:46Z

📌 Commit e86588e has been approved by Mark-Simulacrum

bors · 2017-05-19T11:55:00Z

⌛ Testing commit e86588e with merge 9963379...

bors · 2017-05-19T12:27:25Z

💔 Test failed - status-appveyor

alexcrichton · 2017-05-19T14:08:43Z

@bors: retry

appveyor network issues Tracking issue for spurious network failures on bots #40474

Give a nicer error for non-Unicode arguments to rustc and rustdoc Previously, any non-Unicode argument would panic rustc: ``` $ rustc $'foo\x80bar' error: internal compiler error: unexpected panic note: the compiler unexpectedly panicked. this is a bug. note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports thread 'rustc' panicked at 'called `Result::unwrap()` on an `Err` value: "foo�bar"', /checkout/src/libcore/result.rs:859 note: Run with `RUST_BACKTRACE=1` for a backtrace. ``` Now it gives a clean error: ``` $ rustc $'foo\x80bar' error: Argument 1 is not valid Unicode: "foo�bar" ``` Maybe fixes rust-lang#15890, although we still can't *compile* arbitrary file names.

Rollup of 17 pull requests - Successful merges: #41870, #41910, #41958, #41971, #42006, #42024, #42037, #42056, #42067, #42070, #42079, #42080, #42082, #42089, #42092, #42096, #42100 - Failed merges:

rust-highfive assigned pnkfelix May 18, 2017

shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 19, 2017

Mark-Simulacrum mentioned this pull request May 19, 2017

Rollup of 17 pull requests #42105

Merged

bors merged commit e86588e into rust-lang:master May 19, 2017

cuviper deleted the args_os branch September 26, 2017 06:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Give a nicer error for non-Unicode arguments to rustc and rustdoc#42092