Hack around abysmally slow llvm clones#42211
Merged
bors merged 1 commit intorust-lang:masterfrom May 25, 2017
Merged
Conversation
aidanhs
force-pushed
the
aphs-llvm-clone-hacks
branch
from
38b956a to
f20af48
Compare
aidanhs
force-pushed
the
aphs-llvm-clone-hacks
branch
from
f20af48 to
47f8b4a
Compare
Member
|
If we are gonna download a zip file, perhaps it is even faster to put it on S3 (as a future proposal if this PR is accepted). |
Contributor
Author
|
@kennytm note that we'd then have to remember to upload it every time we update LLVM. This way it will 'just work'. Also, github probably has pretty solid caching, I believe that's the point of the codeload.github.com domain. |
Member
|
@bors r+ p=100 |
Collaborator
|
📌 Commit 47f8b4a has been approved by |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 25, 2017
…rk-Simulacrum Hack around abysmally slow llvm clones r? @Mark-Simulacrum (don't r+ yet, let's see what travis says)
bors
added a commit
that referenced
this pull request
May 25, 2017
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @Mark-Simulacrum
(don't r+ yet, let's see what travis says)