Closed
Conversation
Contributor
|
Thanks! can you remove the |
Contributor
Author
|
Will do, do you want this on the |
Contributor
|
Yes, see https://github.com/mozilla/rust/wiki/Note-development-policy (though we could do a better job of making that page easier to find...) |
Contributor
Author
|
Indeed, might I suggest adding a CONTRIBUTING.md file in the root? GitHub will make it visible in the header when someone starts opening a new PR. |
Merged
Contributor
|
Good idea -- I opened #4273 to do that. |
calebcartwright
pushed a commit
to calebcartwright/rust
that referenced
this pull request
Mar 30, 2022
* Fix newlines in JSON output This changes the JSON output to be more consistent about where newlines are included. Previously it only included them between lines in a multiline diff. That meant single line changes were treated a bit weirdly. This changes it to append a newline to every line. When feeding the results into `arc lint` this behaves correctly. I have only done limited testing though, in particular there's a possibility it might not work with files with `\r\n` endings (though that would have been the case before too). Fixes rust-lang#4259 * Update tests # Conflicts: # tests/writemode/target/output.json
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Apr 10, 2025
path: add more Windows tests
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Apr 10, 2025
path: add more Windows tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, compiling produced the following error: