Point at path segment on module not found#43447

estebank · 2017-07-24T02:41:46Z

Point at the correct path segment on a import statement where a module
doesn't exist.

New output:

error[E0432]: unresolved import `std::bar`
 --> <anon>:1:10
  |
1 | use std::bar::{foo1, foo2};
  |          ^^^ Could not find `bar` in `std`

instead of:

error[E0432]: unresolved import `std::bar::foo1`
 --> <anon>:1:16
  |
1 | use std::bar::{foo1, foo2};
  |                ^^^^ Could not find `bar` in `std`

error[E0432]: unresolved import `std::bar::foo2`
 --> <anon>:1:22
  |
1 | use std::bar::{foo1, foo2};
  |                      ^^^^ Could not find `bar` in `std`

Fix #43040.

rust-highfive · 2017-07-24T02:41:58Z

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

estebank · 2017-07-25T02:12:43Z

r? @nikomatsakis

nikomatsakis · 2017-07-25T17:25:09Z

@bors r+

bors · 2017-07-25T17:25:10Z

📌 Commit 1213bb8 has been approved by nikomatsakis

petrochenkov · 2017-07-25T20:14:40Z

src/librustc_resolve/lib.rs

Point at the correct path segment on a import statement where a module doesn't exist. New output: ```rust error[E0432]: unresolved import `std::bar` --> <anon>:1:10 | 1 | use std::bar::{foo1, foo2}; | ^^^ Could not find `bar` in `std` ``` instead of: ```rust error[E0432]: unresolved import `std::bar::foo1` --> <anon>:1:16 | 1 | use std::bar::{foo1, foo2}; | ^^^^ Could not find `bar` in `std` error[E0432]: unresolved import `std::bar::foo2` --> <anon>:1:22 | 1 | use std::bar::{foo1, foo2}; | ^^^^ Could not find `bar` in `std` ```

estebank · 2017-07-26T04:26:14Z

@bors r=nikomatsakis

bors · 2017-07-26T04:26:15Z

📌 Commit 552ff07 has been approved by nikomatsakis

Mark-Simulacrum · 2017-07-26T12:12:34Z

@bors rollup

Point at path segment on module not found Point at the correct path segment on a import statement where a module doesn't exist. New output: ```rust error[E0432]: unresolved import `std::bar` --> <anon>:1:10 | 1 | use std::bar::{foo1, foo2}; | ^^^ Could not find `bar` in `std` ``` instead of: ```rust error[E0432]: unresolved import `std::bar::foo1` --> <anon>:1:16 | 1 | use std::bar::{foo1, foo2}; | ^^^^ Could not find `bar` in `std` error[E0432]: unresolved import `std::bar::foo2` --> <anon>:1:22 | 1 | use std::bar::{foo1, foo2}; | ^^^^ Could not find `bar` in `std` ``` Fix rust-lang#43040.

Rollup of 10 pull requests - Successful merges: #42959, #43447, #43455, #43456, #43458, #43462, #43463, #43465, #43471, #43480 - Failed merges:

rust-highfive assigned pnkfelix Jul 24, 2017

estebank force-pushed the import-span branch from 87f571a to 4cd797e Compare July 24, 2017 06:24

carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2017

estebank force-pushed the import-span branch 3 times, most recently from 8ffc03d to 1213bb8 Compare July 25, 2017 00:39

rust-highfive assigned nikomatsakis and unassigned pnkfelix Jul 25, 2017

nikomatsakis approved these changes Jul 25, 2017

View reviewed changes

petrochenkov reviewed Jul 25, 2017

View reviewed changes

estebank force-pushed the import-span branch from 1213bb8 to 552ff07 Compare July 26, 2017 04:25

Mark-Simulacrum mentioned this pull request Jul 26, 2017

Rollup of 10 pull requests #43487

Merged

bors added a commit that referenced this pull request Jul 26, 2017

Auto merge of #43487 - Mark-Simulacrum:rollup, r=Mark-Simulacrum

599be0d

Rollup of 10 pull requests - Successful merges: #42959, #43447, #43455, #43456, #43458, #43462, #43463, #43465, #43471, #43480 - Failed merges:

bors merged commit 552ff07 into rust-lang:master Jul 26, 2017

estebank mentioned this pull request Nov 24, 2017

one-time diagnostics for private enum variants glob reëxport #46248

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Point at path segment on module not found#43447