Indicate how ChildStd{in,out,err} FDs are closed.#44625

frewsxcv · 2017-09-16T02:59:09Z

frewsxcv · 2017-09-16T03:03:59Z

src/libstd/process.rs

'underlying operating system file descriptor' is a mouthful. very open to other terminology here.

"file handle", maybe? that's just trading one OS's terminology for another's

i'm 🆒 with 'file handle'. do you think "underlying operating system file handle" or "underlying file handle" or "file handle" or something else?

"underlying file handle" was what i had in mind

thanks for the idea! 'underlying file handle' incorporated in the latest force push

frewsxcv · 2017-09-16T03:04:53Z

r? @QuietMisdreavus

frewsxcv · 2017-09-16T03:06:56Z

i thought about throwing 'RAII" somewhere in here but could think of a good way to incorporate it

Fixes rust-lang#41452.

abonander · 2017-09-16T03:23:22Z

Maybe mention for ChildStdin that, if the child process is blocked on input, it will become unblocked? (unless some OS blocks forever when a pipe is closed)

QuietMisdreavus · 2017-09-16T03:50:24Z

@abonander maybe something about how it'll put an end-of-file at the end of whatever's already been written to it?

retep998 · 2017-09-16T11:13:00Z

src/libstd/process.rs


-    /// Configuration for the child process's stdin handle (file descriptor 0).
+    /// Configuration for the child process's standard input (stdin) handle
+    /// (file descriptor 0).


The file descriptor 0 part seems awfully platform specific.

frewsxcv · 2017-09-19T01:06:31Z

@abonander I'm not too familiar with the behavior/semantics of pipes w.r.t this. Does this sound right?

When an instance of ChildStdin is [dropped], the ChildStdin's underlying file handle will be closed. If the child process was blocked on input prior to being dropped, it will become unblocked after dropping.

frewsxcv · 2017-09-22T01:12:26Z

Added a couple more commits. Anyone else have thoughts?

QuietMisdreavus · 2017-09-22T01:15:42Z

Seems good to me. @abonander What do you think about the note of child processes being unblocked?

abonander · 2017-09-22T02:16:02Z

I can't say whether or not it's correct for all platforms but it answers OP's question in the Reddit post that spawned #41452 so I'm happy with it.

QuietMisdreavus · 2017-09-23T15:41:05Z

Since this seems to be all set, i'll go ahead and get this in.

@bors r+ rollup

bors · 2017-09-23T15:41:06Z

📌 Commit 859ebef has been approved by QuietMisdreavus

…etMisdreavus Indicate how ChildStd{in,out,err} FDs are closed. Fixes rust-lang#41452.

Rollup of 4 pull requests - Successful merges: #44103, #44625, #44789, #44795 - Failed merges:

See: rust-lang/rust#44625 rust-lang/rust#45330

frewsxcv mentioned this pull request Sep 16, 2017

Document Drop behavior of ChildStd[in, out, err] #41452

Closed

frewsxcv commented Sep 16, 2017

View reviewed changes

rust-highfive assigned QuietMisdreavus Sep 16, 2017

frewsxcv added 2 commits September 15, 2017 23:22

Indicate how ChildStd{in,out,err} FDs are closed.

a6ef99e

Fixes rust-lang#41452.

Expand some of the std{in,out,err} usages.

a1f9052

frewsxcv force-pushed the frewsxcv-raii-stdin branch from 7105f47 to a1f9052 Compare September 16, 2017 03:22

retep998 reviewed Sep 16, 2017

View reviewed changes

carols10cents added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 18, 2017

frewsxcv added 2 commits September 21, 2017 21:01

Remove platform-specific terminology.

5ee7db6

Add note about being blocked on input.

859ebef

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 23, 2017

Rollup merge of rust-lang#44625 - frewsxcv:frewsxcv-raii-stdin, r=Qui…

3426bf0

…etMisdreavus Indicate how ChildStd{in,out,err} FDs are closed. Fixes rust-lang#41452.

GuillaumeGomez mentioned this pull request Sep 23, 2017

Rollup of 5 pull requests #44791

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 24, 2017

Rollup merge of rust-lang#44625 - frewsxcv:frewsxcv-raii-stdin, r=Qui…

b1a1861

…etMisdreavus Indicate how ChildStd{in,out,err} FDs are closed. Fixes rust-lang#41452.

GuillaumeGomez mentioned this pull request Sep 24, 2017

Rollup of 4 pull requests #44807

Merged

bors added a commit that referenced this pull request Sep 24, 2017

Auto merge of #44807 - GuillaumeGomez:rollup, r=GuillaumeGomez

647aecc

Rollup of 4 pull requests - Successful merges: #44103, #44625, #44789, #44795 - Failed merges:

bors merged commit 859ebef into rust-lang:master Sep 24, 2017

mizzy added a commit to libspecinfra/specinfra that referenced this pull request Nov 27, 2017

Mask mode by 0o7777 because of incompatible change of Rust

85486be

See: rust-lang/rust#44625 rust-lang/rust#45330

mizzy mentioned this pull request Nov 27, 2017

Mask mode by 0o7777 because of incompatible change of Rust libspecinfra/specinfra#67

Merged

Uh oh!

Conversation

frewsxcv commented Sep 16, 2017

Uh oh!

frewsxcv Sep 16, 2017

Choose a reason for hiding this comment

Uh oh!

QuietMisdreavus Sep 16, 2017

Choose a reason for hiding this comment

Uh oh!

frewsxcv Sep 16, 2017

Choose a reason for hiding this comment

Uh oh!

QuietMisdreavus Sep 16, 2017

Choose a reason for hiding this comment

Uh oh!

frewsxcv Sep 16, 2017

Choose a reason for hiding this comment

Uh oh!

frewsxcv commented Sep 16, 2017

Uh oh!

frewsxcv commented Sep 16, 2017

Uh oh!

abonander commented Sep 16, 2017

Uh oh!

QuietMisdreavus commented Sep 16, 2017

Uh oh!

retep998 Sep 16, 2017

Choose a reason for hiding this comment

Uh oh!

frewsxcv commented Sep 19, 2017

Uh oh!

frewsxcv commented Sep 22, 2017

Uh oh!

QuietMisdreavus commented Sep 22, 2017

Uh oh!

abonander commented Sep 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QuietMisdreavus commented Sep 23, 2017

Uh oh!

bors commented Sep 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

abonander commented Sep 22, 2017 •

edited

Loading