Skip to content

add missing docs for MetadataExt#45470

Merged
bors merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:unix-metadata-ext
Nov 7, 2017
Merged

add missing docs for MetadataExt#45470
bors merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:unix-metadata-ext

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 23, 2017

r? @rust-lang/docs

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2017
frewsxcv
frewsxcv reviewed Oct 23, 2017
View reviewed changes
src/libstd/sys/unix/ext/fs.rs Outdated
Copy link
Contributor

@frewsxcv frewsxcv Oct 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no_run?

QuietMisdreavus
QuietMisdreavus reviewed Oct 23, 2017
View reviewed changes
src/libstd/sys/unix/ext/fs.rs Outdated
Copy link
Contributor

@QuietMisdreavus QuietMisdreavus Oct 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the unix module, not linux, so it would be more accurate to use cfg(unix) here. (I would prefer not having this wrapper here at all, but if you're going to keep it then that's my suggestion.)

src/libstd/sys/unix/ext/fs.rs Outdated
Copy link
Contributor

@QuietMisdreavus QuietMisdreavus Oct 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure these should all be 0o200 etc? I didn't think rust had zero-prefix octal notation.

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Oct 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn you're right! Bad assumption. :s

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Oct 27, 2017

Updated.

QuietMisdreavus
QuietMisdreavus reviewed Oct 30, 2017
View reviewed changes
Copy link
Contributor

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for letting this get stale! I have a couple more nits. You can take them or leave them.

src/libstd/sys/unix/ext/fs.rs Outdated
Copy link
Contributor

@QuietMisdreavus QuietMisdreavus Oct 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "the number of blocks allocated to the file, in 512-byte units"? (This is what man 2 stat says on my system. It also has an additional "This may be smaller than st_size/512 when the file has holes," which may also be worth including.)

src/libstd/sys/unix/ext/fs.rs Outdated
Copy link
Contributor

@QuietMisdreavus QuietMisdreavus Oct 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it would be better to grab the trait in its actual home of std::os::unix::fs::MetadataExt, rather than pulling from the unix prelude? Since that's the page that these examples will be living on. >_>

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2017
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Oct 31, 2017

Updated.

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 2, 2017
@carols10cents
Copy link
Member

carols10cents commented Nov 6, 2017

r? @QuietMisdreavus

@QuietMisdreavus
Copy link
Contributor

QuietMisdreavus commented Nov 6, 2017

@bors r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Nov 6, 2017

📌 Commit af1e4f6 has been approved by QuietMisdreavus

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2017
@kennytm kennytm mentioned this pull request Nov 7, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Nov 7, 2017
@kennytm
Rollup merge of rust-lang#45470 - GuillaumeGomez:unix-metadata-ext, r…
53d8c94 
…=QuietMisdreavus

add missing docs for MetadataExt

r? @rust-lang/docs
@kennytm kennytm mentioned this pull request Nov 7, 2017
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Nov 7, 2017
@kennytm
Rollup merge of rust-lang#45470 - GuillaumeGomez:unix-metadata-ext, r…
8074361 
…=QuietMisdreavus

add missing docs for MetadataExt

r? @rust-lang/docs
bors added a commit that referenced this pull request Nov 7, 2017
@bors
Auto merge of #45822 - kennytm:rollup, r=kennytm
7f6417e 
Rollup of 9 pull requests

- Successful merges: #45470, #45588, #45682, #45714, #45751, #45764, #45778, #45782, #45784
- Failed merges:
@bors bors merged commit af1e4f6 into rust-lang:master Nov 7, 2017
@GuillaumeGomez GuillaumeGomez deleted the unix-metadata-ext branch November 7, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@frewsxcv frewsxcv frewsxcv left review comments

@QuietMisdreavus QuietMisdreavus QuietMisdreavus left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@QuietMisdreavus QuietMisdreavus

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez @carols10cents @QuietMisdreavus @bors @frewsxcv @kennytm