Skip to content

Add missing links and examples#45582

Merged
bors merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:doc-unix-missing-links
Nov 8, 2017
Merged

Add missing links and examples#45582
bors merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:doc-unix-missing-links

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 27, 2017

r? @rust-lang/docs

@frewsxcv
Copy link
Contributor

frewsxcv commented Oct 28, 2017

looks like you have some broken links

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 28, 2017
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Oct 28, 2017

Indeed. I'll fix this as soon as I can.

ollie27
ollie27 reviewed Oct 29, 2017
View reviewed changes
src/libstd/sys/unix/ext/fs.rs Outdated
Copy link
Contributor

@ollie27 ollie27 Oct 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing ``` for all of these examples.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Oct 31, 2017

Added missing ```.

kennytm
kennytm reviewed Nov 2, 2017
View reviewed changes
src/libstd/sys/unix/ext/fs.rs Outdated
Copy link
Member

@kennytm kennytm Nov 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still broken links (not enough ../)

[01:12:39] std/os/unix/fs/trait.DirEntryExt.html:54: broken link - std/std/fs/struct.DirEntry.html

[01:12:39] std/os/unix/fs/index.html:59: broken link - std/std/fs/struct.DirBuilder.html

[01:12:39] std/os/unix/fs/index.html:66: broken link - std/std/fs/struct.DirEntry.html

[01:12:39] std/os/unix/fs/index.html:73: broken link - std/std/fs/struct.File.html

[01:12:39] std/os/unix/fs/trait.FileExt.html:55: broken link - std/std/fs/struct.File.html

[01:12:39] std/os/unix/fs/trait.DirBuilderExt.html:54: broken link - std/std/fs/struct.DirBuilder.html

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Nov 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot a .. once again...

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Nov 4, 2017

Fixed.

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 5, 2017
QuietMisdreavus
QuietMisdreavus reviewed Nov 6, 2017
View reviewed changes
src/libstd/sys/unix/ext/fs.rs Outdated
Copy link
Contributor

@QuietMisdreavus QuietMisdreavus Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you import the trait from std::os::unix::fs::FileTypeExt instead?

Copy link
Contributor

@frewsxcv frewsxcv Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same goes for the other imports in these examples

frewsxcv
frewsxcv approved these changes Nov 7, 2017
View reviewed changes
Copy link
Contributor

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with @QuietMisdreavus's comment (and maybe mine) addressed. nice work! ✨

src/libstd/sys/unix/ext/fs.rs Outdated
Copy link
Contributor

@frewsxcv frewsxcv Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onder if this might be better worded as:

/// Add support for special unix types (block/char device, fifo and socket).

src/libstd/sys/unix/ext/fs.rs Outdated
Copy link
Contributor

@frewsxcv frewsxcv Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same goes for the other imports in these examples

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2017
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Nov 8, 2017

@bors: r=frewsxcv rollup

@bors
Copy link
Collaborator

bors commented Nov 8, 2017

📌 Commit cef0573 has been approved by frewsxcv

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 8, 2017
@GuillaumeGomez
Rollup merge of rust-lang#45582 - GuillaumeGomez:doc-unix-missing-lin…
0f6e010 
…ks, r=frewsxcv

Add missing links and examples

r? @rust-lang/docs
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 8, 2017
Merged
@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2017
bors added a commit that referenced this pull request Nov 8, 2017
@bors
Auto merge of #45862 - GuillaumeGomez:rollup, r=GuillaumeGomez
f733f48 
Rollup of 4 pull requests

- Successful merges: #45582, #45766, #45830, #45849
- Failed merges:
@bors bors merged commit cef0573 into rust-lang:master Nov 8, 2017
@GuillaumeGomez GuillaumeGomez deleted the doc-unix-missing-links branch November 8, 2017 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm left review comments

+3 more reviewers

@QuietMisdreavus QuietMisdreavus QuietMisdreavus left review comments

@ollie27 ollie27 ollie27 left review comments

@frewsxcv frewsxcv frewsxcv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez @frewsxcv @bors @kennytm @QuietMisdreavus @ollie27