Add missing links and examples for FileExt

[GuillaumeGomez]

r? @rust-lang/docs

[kennytm]

[00:03:41] tidy error: /checkout/src/libstd/sys/unix/ext/fs.rs:90: trailing whitespace

[GuillaumeGomez]

Updated.

[frewsxcv]

What do you think about adding ? at the end of the method call instead of ignoring the result?

[GuillaumeGomez]

I could just remove the ';'.

[kennytm]

Broken link, needs one more ../.

[01:13:11] std/os/unix/fs/trait.FileExt.html:70: broken link - std/std/fs/struct.File.html
[01:13:11] std/os/unix/fs/trait.FileExt.html:95: broken link - std/std/fs/struct.File.html
[01:13:20] thread 'main' panicked at 'found some broken links', /checkout/src/tools/linkchecker/main.rs:49:8
[01:13:20] note: Run with `RUST_BACKTRACE=1` for a backtrace.

[ollie27]

This will only read up to 8 bytes so I think it's important to do something with the value read_at returns in this example. The same goes for write_at.

[GuillaumeGomez]

Good point.

[frewsxcv]

maybe something like this?

// Read up to 8 bytes from the offset 10.
let num_bytes_read = file.read_at(buf, 10)?;
println!("read {} bytes: {:?}", num_bytes_read, buf);

[carols10cents]

r? @frewsxcv

[QuietMisdreavus]

Can you make this let mut buf = [0u8; 8]; and pass &mut buf to read_at? That way it'll match what we have in std::io::Read.

[GuillaumeGomez]

Hum sure.

[QuietMisdreavus]

Why did you use read.v instead of method.read? I know they go to the same spot but i'm more used to reading the method. style link anchors. (Same for write farther down.)

[GuillaumeGomez]

It's not targetting the same thing actually. :)

[QuietMisdreavus]

I would consider "the first child element of a container versus the container itself" to be close enough.

[GuillaumeGomez]

Hum, good point.

[frewsxcv]

r=me with @QuietMisdreavus's and @ollie27's comments addressed

[frewsxcv]

maybe something like this?

// Read up to 8 bytes from the offset 10.
let num_bytes_read = file.read_at(buf, 10)?;
println!("read {} bytes: {:?}", num_bytes_read, buf);

[frewsxcv]

this is not guaranteed to read 8 bytes, so phrasing it as 'up to 8 bytes' is a bit more accurate

[bors]

☔ The latest upstream changes (presumably #45862) made this pull request unmergeable. Please resolve the merge conflicts.

[frewsxcv]

r=me with merge conflicts addressed

[GuillaumeGomez]

@bors: r=frewsxcv rollup

[bors]

📌 Commit c09adc4 has been approved by frewsxcv