make coercions to `!` in unreachable code a hard error#45880

arielb1 · 2017-11-08T22:47:48Z

This was added to cover up a lazy extra semicolon in #35849, but does
not actually make sense. This is removed as a part of the stabilization
of never_type.

arielb1 · 2017-11-08T22:48:01Z

cc @Mark-Simulacrum

Mark-Simulacrum · 2017-11-08T23:59:30Z

@bors try

bors · 2017-11-08T23:59:41Z

⌛ Trying commit 2dd1dbfc3041345ba17a9d372412f01eb13a0d32 with merge 371771a40e0262d2b480f622def0e79a1e4b378c...

bors · 2017-11-09T01:35:12Z

☀️ Test successful - status-travis
State: approved= try=True

Mark-Simulacrum · 2017-11-09T14:30:56Z

Crater started.

nikomatsakis · 2017-11-10T11:16:04Z

Nice.

alexcrichton · 2017-11-12T18:35:40Z

r? @eddyb

(just making sure this has an assigned reviewer)

eddyb · 2017-11-12T18:58:50Z

LGTM, if we actually want to do this, I guess.

Mark-Simulacrum · 2017-11-13T13:58:20Z

Please rebase onto master and run another try build to pick up fixes in Cargo.

arielb1 · 2017-11-15T12:43:07Z

@Mark-Simulacrum

Force push done. Waiting for another crater run.

Mark-Simulacrum · 2017-11-15T12:57:17Z

@bors try

[needs crater] make coercions to `!` in unreachable code a hard error This was added to cover up a lazy extra semicolon in #35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.

bors · 2017-11-15T12:57:27Z

⌛ Trying commit 491d128 with merge b53e6a8...

bors · 2017-11-15T15:42:43Z

☀️ Test successful - status-travis
State: approved= try=True

aidanhs · 2017-11-21T17:52:35Z

Crater run started

aidanhs · 2017-11-26T14:13:41Z

Hi @arielb1 (crater requester), @eddyb (reviewer)! Crater results are at: http://cargobomb-reports.s3.amazonaws.com/pr-45580/index.html. 'Blacklisted' crates (spurious failures etc) can be found
here. If you see any spurious failures not on the list, please make a PR against that file.

arielb1 · 2017-11-26T15:55:10Z

All failures look spurious.

arielb1 · 2017-11-26T15:56:21Z

I suppose we'll merge this with deny-by-default, given that there were no failures on crater

r? @nikomatsakis

mzji · 2017-11-30T01:41:25Z

src/librustc_lint/lib.rs

        },
+        FutureIncompatibleInfo {
+            id: LintId::of(COERCE_NEVER),
+            reference: "issue #46325 <https://github.com/rust-lang/rust/issues/42869>",


This link should be fixed (point to an issue related to never type coercion).

mzji · 2017-11-30T01:41:51Z

src/test/ui/reachable/expr_unary.stderr

+15 | #![deny(coerce_never)]
+   |         ^^^^^^^^^^^^
+   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
+   = note: for more information, see issue #46325 <https://github.com/rust-lang/rust/issues/42869>


And this link.

make coercions to `!` in unreachable code a hard error This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.

This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.

arielb1 · 2017-11-30T13:18:37Z

@bors r=nikomatsakis rollup

bors · 2017-11-30T13:18:37Z

📌 Commit 5a00b7c has been approved by nikomatsakis

make coercions to `!` in unreachable code a hard error This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.

Rollup of 13 pull requests - Successful merges: #45880, #46280, #46373, #46376, #46385, #46386, #46387, #46392, #46400, #46401, #46405, #46412, #46421 - Failed merges:

arielb1 added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Nov 8, 2017

rust-highfive assigned eddyb Nov 12, 2017

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 13, 2017

arielb1 force-pushed the never-coerce branch from 2dd1dbf to 491d128 Compare November 15, 2017 12:42

kennytm added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2017

rust-highfive assigned nikomatsakis and unassigned eddyb Nov 26, 2017

arielb1 changed the title ~~[needs crater] make coercions to ! in unreachable code a hard error~~ make coercions to ! in unreachable code a hard error Nov 26, 2017

kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2017

kennytm removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2017

mzji reviewed Nov 30, 2017

View reviewed changes

arielb1 mentioned this pull request Nov 30, 2017

Rollup of 10 pull requests #46395

Closed

make coercions to ! in unreachable code a hard error

5a00b7c

This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.

arielb1 force-pushed the never-coerce branch from 235de09 to 5a00b7c Compare November 30, 2017 13:18

arielb1 mentioned this pull request Nov 30, 2017

Rollup of 9 pull requests #46398

Closed

arielb1 mentioned this pull request Nov 30, 2017

Rollup of 11 pull requests #46399

Closed

arielb1 mentioned this pull request Nov 30, 2017

Rollup of 10 pull requests #46404

Closed

arielb1 mentioned this pull request Nov 30, 2017

Rollup of 12 pull requests #46410

Closed

kennytm mentioned this pull request Dec 1, 2017

Rollup of 13 pull requests #46430

Merged

bors added a commit that referenced this pull request Dec 1, 2017

Auto merge of #46430 - kennytm:rollup, r=kennytm

7051754

Rollup of 13 pull requests - Successful merges: #45880, #46280, #46373, #46376, #46385, #46386, #46387, #46392, #46400, #46401, #46405, #46412, #46421 - Failed merges:

bors merged commit 5a00b7c into rust-lang:master Dec 2, 2017

nikomatsakis mentioned this pull request Dec 6, 2017

Settle desired semantics of divergence for purposes of coercion #40800

Closed

nikomatsakis mentioned this pull request Apr 30, 2018

we still sometimes permit coercion into ! #50350

Closed

ehuss mentioned this pull request Jun 2, 2021

Confused by diverging type of block tail expression #85936

Closed

traviscross mentioned this pull request Jul 16, 2024

Document when the return type of a block expression implicitly becomes ! rust-lang/reference#1033

Closed

Uh oh!

Conversation

arielb1 commented Nov 8, 2017

Uh oh!

arielb1 commented Nov 8, 2017

Uh oh!

Mark-Simulacrum commented Nov 8, 2017

Uh oh!

bors commented Nov 8, 2017

Uh oh!

bors commented Nov 9, 2017

Uh oh!

Mark-Simulacrum commented Nov 9, 2017

Uh oh!

nikomatsakis commented Nov 10, 2017

Uh oh!

alexcrichton commented Nov 12, 2017

Uh oh!

eddyb commented Nov 12, 2017

Uh oh!

Mark-Simulacrum commented Nov 13, 2017

Uh oh!

arielb1 commented Nov 15, 2017

Uh oh!

Mark-Simulacrum commented Nov 15, 2017

Uh oh!

bors commented Nov 15, 2017

Uh oh!

bors commented Nov 15, 2017

Uh oh!

aidanhs commented Nov 21, 2017

Uh oh!

aidanhs commented Nov 26, 2017

Uh oh!

arielb1 commented Nov 26, 2017

Uh oh!

arielb1 commented Nov 26, 2017

Uh oh!

mzji Nov 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mzji Nov 30, 2017

Choose a reason for hiding this comment

Uh oh!

arielb1 commented Nov 30, 2017

Uh oh!

bors commented Nov 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mzji Nov 30, 2017 •

edited

Loading