Incoming

[mneumann]

Please see especially the rewrite of TcpSocketBuf.read which fixes a performance bug.

[bstrie]

For future reference, you can aim pull requests at the incoming branch by clicking on the black box that says mozilla:master and changing it to mozilla:incoming.

[mneumann]

ok!

[brson]

Thanks! Merged.

[huonw]

Doesn't the read_line change break UTF8 since it changes how the character interpretation happens (each byte is interpreted as an entire code point in the new version, rather than as (possibly) part of a longer sequence of bytes making up a single character): e.g. if someone typed å (code point 0xE5, 0xC3 0xA5 in UTF8)

fn main() {
    // old version
    let b = ~[0xC3u8, 0xA5];
    io::println(str::from_bytes(b)); // prints 'å'

    // new version
    let mut s = ~"";
    str::push_char(&mut s,0xC3 as char);
    str::push_char(&mut s,0xA5 as char);
    io::println(s); // prints 'Ã¥'

}

[brson]

@dbaupp Yes, you are right. I will add a test and revert.

[mneumann]

I think instead it would be save to do at the end bytes.push(0) followed by a return cast::transmute(bytes).