Remove librustdoc dependency on log#46503
Conversation
This change should have been included in PR rust-lang#46386. Since librustdoc doesn't explicitly depend on internal crates (such as librustc_driver) through its Cargo.toml, it ends up using the sysroot to resolve them. By removing the dependency on 'log', we ensure that the syroot is used to resolve `log` as well. This ensures that only one version of log is in use, so that `env_logger::init()` enables all uses of `log!` macros.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ |
|
📌 Commit f6d3900 has been approved by |
Remove librustdoc dependency on log This change should have been included in PR #46386. Since librustdoc doesn't explicitly depend on internal crates (such as librustc_driver) through its Cargo.toml, it ends up using the sysroot to resolve them. By removing the dependency on 'log', we ensure that the syroot is used to resolve `log` as well. This ensures that only one version of log is in use, so that `env_logger::init()` enables all uses of `log!` macros.
|
☀️ Test successful - status-appveyor, status-travis |
5 participants
This change should have been included in PR #46386.
Since librustdoc doesn't explicitly depend on internal crates
(such as librustc_driver) through its Cargo.toml, it ends up using the
sysroot to resolve them. By removing the dependency on 'log',
we ensure that the syroot is used to resolve
logas well. This ensuresthat only one version of log is in use, so that
env_logger::init()enables all uses of
log!macros.