Conversation
The usage of `Path::new` prevented out-of-tree builds (like the bots do) from working by accident! Closes rust-lang#46195
Contributor
|
|
Member
|
@bors: r+ |
Collaborator
|
📌 Commit 336a27c has been approved by |
kennytm
added
the
S-waiting-on-bors
Member
|
🤔 CI is failing because external factors are still not fixed. @steveklabnik Could you backport #46715 and #46694 together? Otherwise I'm afraid bors won't be happy (yes http://crosstool-ng.org/ is still offline). |
Contributor
Author
|
I can try to roll them into these PRs... |
Temporary workaround since crosstool-ng.org was down. Consider mirroring the release tarball as a more permanent solution.
Use it until travis-ci/travis-ci#8891 is fixed.
Contributor
Author
|
Let's see how this goes. |
Contributor
Author
|
Looks like it passed! @bors: r=alexcrichton |
Collaborator
|
📌 Commit bc3e2ae has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Dec 16, 2017
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton