rustc: use {U,I}size instead of {U,I}s shorthands.#47170
Merged
bors merged 2 commits intorust-lang:masterfrom Jan 6, 2018
Merged
rustc: use {U,I}size instead of {U,I}s shorthands.#47170bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
kennytm
added
the
S-waiting-on-review
nikomatsakis
reviewed
Jan 4, 2018
Contributor
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
This change seems fine, but it surprises me to see any change in behavior due to it...?
| 21 | a as isize; //~ ERROR casting | ||
| | ^^^^^^^^^^ | ||
| | | ||
| = help: cast through a raw pointer first |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 210ac01 has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 6, 2018
rustc: use {U,I}size instead of {U,I}s shorthands.
`Us`/`Is` come from a time when `us` and `is` were the literal suffixes that are now `usize` / `isize`.
r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Jan 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Us/Iscome from a time whenusandiswere the literal suffixes that are nowusize/isize.r? @nikomatsakis