rustc_trans: take into account primitives larger than 8 bytes.#47437
Closed
eddyb wants to merge 1 commit intorust-lang:masterfrom
Closed
rustc_trans: take into account primitives larger than 8 bytes.#47437eddyb wants to merge 1 commit intorust-lang:masterfrom
eddyb wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
r? @nagisa |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 5934174 has been approved by |
Collaborator
|
☔ The latest upstream changes (presumably #47209) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
Author
|
@bors r=nagisa |
Collaborator
|
📌 Commit cbeebc5 has been approved by |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 25, 2018
rustc_trans: take into account primitives larger than 8 bytes. Fixes rust-lang#38763 by marking all "eightbytes" covered by a primitive appropriately, not just the first.
Member
|
@bors r- This PR failed in the rollup #47748 because Emscripten doesn't support i128. Please apply 68f2e1e: From 68f2e1ebf2e0f959685fbce3f69349b3e21f34cc Mon Sep 17 00:00:00 2001
From: Alex Crichton <alex@alexcrichton.com>
Date: Thu, 25 Jan 2018 21:04:01 -0800
Subject: [PATCH] Ignore an i128 test on emscripten
---
src/test/run-pass/issue-38763.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/test/run-pass/issue-38763.rs b/src/test/run-pass/issue-38763.rs
index 4bf9513d64f9..01cc8265a399 100644
--- a/src/test/run-pass/issue-38763.rs
+++ b/src/test/run-pass/issue-38763.rs
@@ -8,6 +8,8 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.
+// ignore-emscripten
+
#![feature(i128_type)]
#[repr(C)] |
Member
Author
|
@bors r=nagisa |
Collaborator
|
📌 Commit 035eee8 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 26, 2018
Member
|
Already merged as part of #47748 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38763 by marking all "eightbytes" covered by a primitive appropriately, not just the first.