private no-mangle lints: only suggest `pub` if it doesn't already exist#47479

zackmdavis · 2018-01-16T02:53:06Z

Fixes #47383 (function or static can be pub but unreachable because it's in a private module; adding another pub is nonsensical).

r? @estebank

estebank · 2018-01-16T05:28:27Z

r=me once the test is fixed.

The incompetent fool who added these suggestions in 38e5a96 apparently thought it was safe to assume that, because the offending function or static was unreachable, it would therefore have not have any existing visibility modifiers, making it safe for us to unconditionally suggest inserting `pub`. This isn't true. This resolves rust-lang#47383.

petrochenkov · 2018-01-16T08:37:35Z

I don't think this is a correct fix.
Until #47384 is changed this lint should be based on reachability as well.
Otherwise you'll get no_mangle items to which you can't link, but no lint is reported.

zackmdavis · 2018-01-16T23:50:24Z

@petrochenkov

Until #47384 is changed this lint should be based on reachability as well. Otherwise you'll get no_mangle items to which you can't link, but no lint is reported.

I'm confused: as I understand, the lint is based on reachability (if !cx.access_levels.is_reachable( ...). This PR doesn't change that; this PR just makes it so that the lint warning doesn't additionally have a "try making it pub" suggestion span when there's already a pub. But the lint is still triggered: notice that the two #[no-mangle] pub items added to the UI test result in two more lint warnings appearing in the output.

estebank · 2018-01-17T01:23:30Z

@bors r+ rollup

bors · 2018-01-17T01:23:31Z

📌 Commit 661e033 has been approved by estebank

petrochenkov · 2018-01-17T09:00:26Z

Ah, I see, only the help note is disabled, then it's ok.

@estebank

…ested_double-pub, r=estebank private no-mangle lints: only suggest `pub` if it doesn't already exist Fixes rust-lang#47383 (function or static can be `pub` but unreachable because it's in a private module; adding another `pub` is nonsensical). r? @estebank

@estebank

…ested_double-pub, r=estebank private no-mangle lints: only suggest `pub` if it doesn't already exist Fixes rust-lang#47383 (function or static can be `pub` but unreachable because it's in a private module; adding another `pub` is nonsensical). r? @estebank

Rollup of 21 pull requests - Successful merges: #47302, #47333, #47387, #47404, #47407, #47426, #47427, #47436, #47444, #47456, #47458, #47467, #47479, #47481, #47483, #47487, #47497, #47498, #47505, #47509, #47514 - Failed merges:

rust-highfive assigned estebank Jan 16, 2018

zackmdavis force-pushed the and_the_case_of_the_suggested_double-pub branch from 56520b3 to 1f2a1c2 Compare January 16, 2018 04:44

kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 16, 2018

zackmdavis force-pushed the and_the_case_of_the_suggested_double-pub branch from 1f2a1c2 to 661e033 Compare January 16, 2018 08:31

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 16, 2018

kennytm mentioned this pull request Jan 17, 2018

Rollup of 19 pull requests #47513

Closed

kennytm mentioned this pull request Jan 17, 2018

Rollup of 21 pull requests #47522

Merged

bors merged commit 661e033 into rust-lang:master Jan 17, 2018

petrochenkov mentioned this pull request Jan 19, 2018

Rust wants me to write pub pub #47565

Closed

zackmdavis mentioned this pull request Mar 21, 2018

Need more helpful warning when "pub extern" function is not exported via "pub use" #49238

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

private no-mangle lints: only suggest `pub` if it doesn't already exist#47479