Closure argument mismatch tweaks#47573
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 21, 2018
Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
varkor
reviewed
Jan 19, 2018
Contributor
Author
There was a problem hiding this comment.
Yeah, there're a bunch of code I'm none too happy with, I'll clean it up as much as possible before merging.
nikomatsakis
approved these changes
Jan 19, 2018
Contributor
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
r=me once travis errors are fixed
estebank
added
S-waiting-on-review
estebank
force-pushed
the
closures
branch
3 times, most recently
from
ca99f6b to
0ce008a
Compare
- use consistent phrasing for expected and found arguments - suggest changing arugments to tuple if possible - suggest changing single tuple argument to arguments if possible
Contributor
Author
|
@bors r=nikomatsakis |
Collaborator
|
📌 Commit 7ed00ca has been approved by |
Contributor
Author
|
@bors rollup |
estebank
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 20, 2018
Closure argument mismatch tweaks - use consistent phrasing for expected and found arguments - suggest changing arguments to tuple if possible - suggest changing single tuple argument to arguments if possible Fix rust-lang#44150.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #44150.