Do not capture stderr in the compiler. Instead just panic silently for fatal errors#47634
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 26, 2018
Merged
Do not capture stderr in the compiler. Instead just panic silently for fatal errors#47634bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
T-compiler
Contributor
Contributor
Author
Member
|
@bors: r+ Thanks! |
Collaborator
|
📌 Commit 124605a has been approved by |
Contributor
Author
|
@bors r=alexcrichton |
Collaborator
|
📌 Commit 9a8d6b8 has been approved by |
Member
|
Is there a chance that this PR would have changed the error message when a custom derive panics? #47812 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also has the side-effect of making printing to stderr work in the compiler.