Skip to content

Run rustfmt and add doc comments to libsyntax/ext/tt/macro_parser.rs#47732

Merged
bors merged 7 commits intorust-lang:masterfrom
mark-i-m:markim_comments_0001
Jan 30, 2018
Merged

Run rustfmt and add doc comments to libsyntax/ext/tt/macro_parser.rs#47732
bors merged 7 commits intorust-lang:masterfrom
mark-i-m:markim_comments_0001

Conversation

@mark-i-m
Copy link
Contributor

@mark-i-m mark-i-m commented Jan 25, 2018

Similar to #47603

cc @theotherphil since you reviewed my other PR 😄

And because they are already assigned on #47603:

r? @arielb1

@rust-highfive
Copy link
Contributor

rust-highfive commented Jan 25, 2018

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@mark-i-m mark-i-m mentioned this pull request Jan 25, 2018
Merged
@kennytm kennytm mentioned this pull request Jan 25, 2018
Merged
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2018
@bors
Copy link
Collaborator

bors commented Jan 26, 2018

☔ The latest upstream changes (presumably #47748) made this pull request unmergeable. Please resolve the merge conflicts.

@mark-i-m mark-i-m force-pushed the markim_comments_0001 branch from c2a98c8 to e2d558a Compare January 26, 2018 20:47
@mark-i-m mark-i-m mentioned this pull request Jan 27, 2018
Merged
@arielb1
Copy link
Contributor

arielb1 commented Jan 29, 2018

r? @jsseyfried

@arielb1
Copy link
Contributor

arielb1 commented Jan 29, 2018

r? @jseyfried

@rust-highfive rust-highfive assigned jseyfried and unassigned arielb1 Jan 29, 2018
jseyfried
jseyfried reviewed Jan 29, 2018
View reviewed changes
src/libsyntax/ext/tt/macro_parser.rs Outdated
}

impl TokenTreeOrTokenTreeVec {
/// Returns the number of constituent token trees of `self`.
Copy link
Contributor

@jseyfried jseyfried Jan 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe: constituent top level token trees.

Copy link
Contributor Author

@mark-i-m mark-i-m Jan 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@jseyfried
Copy link
Contributor

jseyfried commented Jan 29, 2018 •
edited
Loading

Excellent, thanks! This is ancient code and IMO some of the most difficult in libsyntax to understand.
@bors r+

@bors
Copy link
Collaborator

bors commented Jan 29, 2018

📌 Commit 2184400 has been approved by jseyfried

@mark-i-m
Copy link
Contributor Author

mark-i-m commented Jan 29, 2018

Lol, yes... git blame shows that most of it hasn't really been touched in years. It took me a couple of weeks to work through it 😛

@rust-lang rust-lang deleted a comment from bors Jan 29, 2018
@rust-lang rust-lang deleted a comment from bors Jan 29, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jan 30, 2018
@kennytm
Rollup merge of rust-lang#47732 - mark-i-m:markim_comments_0001, r=js…
f06a391 
…eyfried

Run rustfmt and add doc comments to libsyntax/ext/tt/macro_parser.rs

Similar to rust-lang#47603

cc @theotherphil since you reviewed my other PR 😄

And because they are already assigned on rust-lang#47603:

r? @arielb1
@kennytm kennytm mentioned this pull request Jan 30, 2018
Merged
bors added a commit that referenced this pull request Jan 30, 2018
@bors
Auto merge of #47870 - kennytm:rollup, r=kennytm
def3269 
Rollup of 12 pull requests

- Successful merges: #47515, #47603, #47718, #47732, #47760, #47780, #47822, #47826, #47836, #47839, #47853, #47855
- Failed merges:
@bors bors merged commit 2184400 into rust-lang:master Jan 30, 2018
@mark-i-m mark-i-m deleted the markim_comments_0001 branch November 14, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jseyfried jseyfried jseyfried left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jseyfried jseyfried

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mark-i-m @rust-highfive @bors @arielb1 @jseyfried @kennytm