Hide theme button under menu in mobile mode and fix top margin issue …#48080

GuillaumeGomez · 2018-02-08T22:48:41Z

…(in mobile too)

QuietMisdreavus · 2018-02-09T03:39:50Z

@bors r+ rollup

The "darker margin on the header" thing may be some kind of artifact of using a desktop browser? The screenshot on the issue was taken in Chrome in Windows 7. A similar effect happens in Firefox on Windows 10:

big screenshot

However, when testing on my iPhone 7 Plus in mobile Safari, i see no such artifact:

big screenshot

In addition, @GuillaumeGomez was unable to recreate the issue at all. I'm willing to write it off at this point. I wonder if it has something to do with the scroll bar indicator, and it's just the way it looks when it overlaps the bar? That would explain why it's narrower on the Firefox screenshot. It does not explain why the coloring changes when the menu is open, but the finer points of that are beyond me.

bors · 2018-02-09T03:39:51Z

📌 Commit e9bcb4e has been approved by QuietMisdreavus

GuillaumeGomez · 2018-02-09T09:23:07Z

I'll try to recreate the bug. You said firefox? Then on firefox I'll check. :)

…=QuietMisdreavus Hide theme button under menu in mobile mode and fix top margin issue … Fixes rust-lang#48060.

Rollup of 12 pull requests - Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064, #47790, #48059, #48078, #48080, #48085 - Failed merges:

@QuietMisdreavus

…=QuietMisdreavus Hide theme button under menu in mobile mode and fix top margin issue … Fixes rust-lang#48060. r? @QuietMisdreavus

Rollup of 17 pull requests - Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48085, #48086, #48090, #48093, #48098, #48101 - Failed merges:

@QuietMisdreavus

…=QuietMisdreavus Hide theme button under menu in mobile mode and fix top margin issue … Fixes rust-lang#48060. r? @QuietMisdreavus

Rollup of 16 pull requests - Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100 - Failed merges:

Rollup of 20 pull requests - Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100, #48085, #48120, #48124, #47547 - Failed merges:

Hide theme button under menu in mobile mode and fix top margin issue …

e9bcb4e

…(in mobile too)

rust-highfive assigned QuietMisdreavus Feb 8, 2018

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 9, 2018

kennytm mentioned this pull request Feb 9, 2018

Rollup of 12 pull requests #48077

Closed

kennytm added a commit to kennytm/rust that referenced this pull request Feb 9, 2018

Rollup merge of rust-lang#48080 - GuillaumeGomez:mobile-docs-fixes, r…

434865d

…=QuietMisdreavus Hide theme button under menu in mobile mode and fix top margin issue … Fixes rust-lang#48060.

bors added a commit that referenced this pull request Feb 9, 2018

Auto merge of #48077 - kennytm:rollup, r=kennytm

68df9d6

Rollup of 12 pull requests - Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064, #47790, #48059, #48078, #48080, #48085 - Failed merges:

kennytm mentioned this pull request Feb 9, 2018

Rollup of 17 pull requests #48104

Closed

kennytm mentioned this pull request Feb 10, 2018

Rollup of 20 pull requests #48113

Merged

bors merged commit e9bcb4e into rust-lang:master Feb 10, 2018

GuillaumeGomez deleted the mobile-docs-fixes branch February 12, 2018 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Hide theme button under menu in mobile mode and fix top margin issue …#48080