Automatically enable the `clippy` feature of `rls` if clippy builds#48097

oli-obk · 2018-02-09T17:54:15Z

r? @nrc

cc @Manishearth

kennytm · 2018-02-09T20:29:43Z

src/bootstrap/lib.rs

Why expand this into 4 lines 🤔

So future changes to the feature list are simpler

We usually just write multiple #![feature] attributes though

nrc · 2018-02-12T02:09:58Z

@bors: r+

bors · 2018-02-12T02:09:59Z

📌 Commit 8a4ca24 has been approved by nrc

kennytm · 2018-02-14T10:08:11Z

@bors r-

Cannot find the commit 0d1fd8f7669587dbfc47aea565ef60a53e3bf4d9 for the RLS submodule. Perhaps this is due to rust-lang/rls#707 being closed. Please change the submodule to something in the remote repository.

[00:01:28] error: no such remote ref 0d1fd8f7669587dbfc47aea565ef60a53e3bf4d9
[00:01:28] Fetched in submodule path 'src/tools/rls', but it did not contain 0d1fd8f7669587dbfc47aea565ef60a53e3bf4d9. Direct fetching of that commit failed.

bors · 2018-02-15T07:33:58Z

☔ The latest upstream changes (presumably #48202) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2018-02-16T12:49:52Z

rebased and adjusted submodule references

kennytm · 2018-02-16T14:04:51Z

@bors r=nrc

bors · 2018-02-16T14:04:51Z

📌 Commit 99f774e has been approved by nrc

bors · 2018-02-24T10:43:44Z

☔ The latest upstream changes (presumably #48476) made this pull request unmergeable. Please resolve the merge conflicts.

shepmaster · 2018-03-02T19:27:59Z

Ping from triage, @oli-obk! It's been a few weeks since we've heard from you, will you have time to address the merge conflicts?

oli-obk · 2018-03-06T14:45:56Z

@bors r=nrc

bors · 2018-03-06T14:45:57Z

📌 Commit 6fa8d33 has been approved by nrc

bors · 2018-03-08T10:10:29Z

📌 Commit 6f15e82 has been approved by nrc

oli-obk · 2018-03-08T11:47:15Z

@bors r- you don't need to waste time on this now that the miri PR broke clippy

bors · 2018-03-11T23:17:59Z

☔ The latest upstream changes (presumably #48549) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2018-03-16T17:24:55Z

Do not merge before rust-lang/rls#768 is merged

mati865 · 2018-03-16T18:34:49Z

rust-lang/rls#768 was merged

oli-obk · 2018-03-16T18:51:04Z

@bors r=nrc

bors · 2018-03-16T18:51:04Z

📌 Commit 02ac15c has been approved by nrc

bors · 2018-03-16T19:45:17Z

⌛ Testing commit 02ac15c with merge 55c984e...

@nrc

…=nrc Automatically enable the `clippy` feature of `rls` if clippy builds r? @nrc cc @Manishearth

bors · 2018-03-16T22:43:28Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing 55c984e to master...

kennytm-githubbot · 2018-03-16T22:44:59Z

📣 Toolstate changed by #48097!

Tested on commit 55c984e.
Direct link to PR: #48097

🎉 clippy-driver on windows: build-fail → test-fail.
🎉 clippy-driver on linux: build-fail → test-fail.

Tested on commit rust-lang/rust@55c984e. Direct link to PR: <rust-lang/rust#48097> 🎉 clippy-driver on windows: build-fail → test-fail. 🎉 clippy-driver on linux: build-fail → test-fail.

This field was introduced in rust-lang#48097 to support the "clippy" feature of RLS.

rust-highfive assigned nrc Feb 9, 2018

kennytm reviewed Feb 9, 2018

View reviewed changes

kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 9, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2018

kennytm mentioned this pull request Feb 14, 2018

Rollup of 23 pull requests #48203

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 14, 2018

oli-obk force-pushed the did_you_mean_to_run_rls_with_clippy branch from 8a4ca24 to 99f774e Compare February 16, 2018 10:21

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 16, 2018

This was referenced Feb 19, 2018

Integration with clippy rust-lang/rls#149

Closed

Stability tracking - Clippy rust-dev-tools/dev-tools-team#18

Open

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2018

oli-obk force-pushed the did_you_mean_to_run_rls_with_clippy branch 2 times, most recently from 19557b0 to 6fa8d33 Compare March 6, 2018 14:41

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 8, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 8, 2018

Automatically enable the clippy feature of rls if clippy builds

02ac15c

oli-obk force-pushed the did_you_mean_to_run_rls_with_clippy branch from 6f15e82 to 02ac15c Compare March 16, 2018 17:24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 16, 2018

bors added a commit that referenced this pull request Mar 16, 2018

Auto merge of #48097 - oli-obk:did_you_mean_to_run_rls_with_clippy, r…

55c984e

…=nrc Automatically enable the `clippy` feature of `rls` if clippy builds r? @nrc cc @Manishearth

bors merged commit 02ac15c into rust-lang:master Mar 16, 2018

kennytm mentioned this pull request May 15, 2018

Don't inject clippy into the rls anymore #50767

Merged

oli-obk deleted the did_you_mean_to_run_rls_with_clippy branch May 15, 2018 09:48

bors pushed a commit to rust-lang-ci/rust that referenced this pull request Jan 2, 2025

Remove the unused extra_features field from tool_extended!

e76c484

This field was introduced in rust-lang#48097 to support the "clippy" feature of RLS.

Uh oh!

Conversation

oli-obk commented Feb 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kennytm Feb 9, 2018

Choose a reason for hiding this comment

Uh oh!

oli-obk Feb 9, 2018

Choose a reason for hiding this comment

Uh oh!

kennytm Feb 9, 2018

Choose a reason for hiding this comment

Uh oh!

nrc commented Feb 12, 2018

Uh oh!

bors commented Feb 12, 2018

Uh oh!

kennytm commented Feb 14, 2018

Uh oh!

bors commented Feb 15, 2018

Uh oh!

oli-obk commented Feb 16, 2018

Uh oh!

kennytm commented Feb 16, 2018

Uh oh!

bors commented Feb 16, 2018

Uh oh!

bors commented Feb 24, 2018

Uh oh!

shepmaster commented Mar 2, 2018

Uh oh!

oli-obk commented Mar 6, 2018

Uh oh!

bors commented Mar 6, 2018

Uh oh!

bors commented Mar 8, 2018

Uh oh!

oli-obk commented Mar 8, 2018

Uh oh!

bors commented Mar 11, 2018

Uh oh!

oli-obk commented Mar 16, 2018

Uh oh!

mati865 commented Mar 16, 2018

Uh oh!

oli-obk commented Mar 16, 2018

Uh oh!

bors commented Mar 16, 2018

Uh oh!

bors commented Mar 16, 2018

Uh oh!

bors commented Mar 16, 2018

Uh oh!

kennytm-githubbot commented Mar 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

oli-obk commented Feb 9, 2018 •

edited

Loading