Continue parsing function after finding `...` arg#48154

estebank · 2018-02-12T06:12:56Z

When encountering a variadic argument in a function definition that
doesn't accept it, if immediately after there's a closing paren,
continue parsing as normal. Otherwise keep current behavior of emitting
error and stopping.

Fix #31481.

When encountering a variadic argument in a function definition that doesn't accept it, if immediately after there's a closing paren, continue parsing as normal. Otherwise keep current behavior of emitting error and stopping.

rust-highfive · 2018-02-12T06:13:02Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

eddyb · 2018-02-12T10:21:34Z

r? @nikomatsakis

kennytm · 2018-02-12T10:50:46Z

Would this conflict with RFC 2137 (#44930)?

estebank · 2018-02-12T16:25:34Z

@kennytm it would have to be removed once that RFC is implemented. In the meantime the current error message is subpar as it swallows later, more relevant errors in the tested case.

nikomatsakis · 2018-02-12T20:28:59Z

@bors r+

bors · 2018-02-12T20:29:00Z

📌 Commit f7cabc6 has been approved by nikomatsakis

estebank · 2018-02-12T22:45:29Z

@bors rollup

Continue parsing function after finding `...` arg When encountering a variadic argument in a function definition that doesn't accept it, if immediately after there's a closing paren, continue parsing as normal. Otherwise keep current behavior of emitting error and stopping. Fix rust-lang#31481.

Rollup of 14 pull requests - Successful merges: #47784, #47846, #48033, #48083, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48163, #48165, #48167 - Failed merges:

Continue parsing function after finding `...` arg When encountering a variadic argument in a function definition that doesn't accept it, if immediately after there's a closing paren, continue parsing as normal. Otherwise keep current behavior of emitting error and stopping. Fix rust-lang#31481.

Rollup of 22 pull requests - Successful merges: #47784, #47806, #47846, #48005, #48033, #48065, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48156, #48162, #48163, #48165, #48167, #48181, #48186, #48195, #48035 - Failed merges:

Rollup of 23 pull requests - Successful merges: #47784, #47806, #47846, #48005, #48033, #48065, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48156, #48162, #48163, #48165, #48167, #48181, #48186, #48195, #48035, #48210 - Failed merges:

Continue parsing function after finding ... arg

f7cabc6

When encountering a variadic argument in a function definition that doesn't accept it, if immediately after there's a closing paren, continue parsing as normal. Otherwise keep current behavior of emitting error and stopping.

rust-highfive assigned eddyb Feb 12, 2018

estebank added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2018

rust-highfive assigned nikomatsakis and unassigned eddyb Feb 12, 2018

nikomatsakis approved these changes Feb 12, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2018

kennytm mentioned this pull request Feb 13, 2018

Rollup of 14 pull requests #48177

Closed

kennytm mentioned this pull request Feb 14, 2018

Rollup of 23 pull requests #48203

Merged

kennytm merged commit f7cabc6 into rust-lang:master Feb 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Continue parsing function after finding `...` arg#48154