Add tests ensuring zero-Duration timeouts result in errors; fix Redox issues.#48330

frewsxcv · 2018-02-18T21:10:03Z

Part of #48311

frewsxcv · 2018-02-18T21:10:11Z

@bors try

rust-highfive · 2018-02-18T21:10:13Z

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

bors · 2018-02-18T21:10:21Z

⌛ Trying commit d45282ab98e6eb20cf0c2fea5945ef3627ed247d with merge e5ec420868711c2004c414664fe666c655a8d94b...

bors · 2018-02-18T21:20:18Z

💔 Test failed - status-travis

frewsxcv · 2018-02-19T02:33:38Z

@bors try

bors · 2018-02-19T02:33:50Z

⌛ Trying commit 2db8a7da8b842ee7b3be83b8c647ae55b31fef0c with merge 0ff0573af24d21ddd66cfee71a1b144b59e521a7...

Part of rust-lang#48311

frewsxcv · 2018-02-19T02:42:26Z

@bors try

bors · 2018-02-19T02:42:36Z

⌛ Trying commit d17d645 with merge 636afc379b28036f1d9e661f55085b22780ffda2...

bors · 2018-02-19T04:46:18Z

☀️ Test successful - status-travis
State: approved= try=True

frewsxcv · 2018-02-19T13:47:18Z

ah, i thought bors try would run on all platforms – looks like it's just linux. in any case, i fixed the redox implementation to return an error if a zero duration is passed (see the latest commit). i don't think there are any other implementations i need to fixup

@sfackler r?

sfackler · 2018-02-20T05:04:18Z

@bors r+

bors · 2018-02-20T05:04:18Z

📌 Commit 0755825 has been approved by sfackler

…on, r=sfackler Add tests ensuring zero-Duration timeouts result in errors; fix Redox issues. Part of rust-lang#48311

kennytm · 2018-02-25T12:23:08Z

@bors r-

This failed to compile on Redox.

Details

[01:04:49] error[E0433]: failed to resolve. Use of undeclared type or module `io`
[01:04:49]    --> libstd/sys/redox/net/tcp.rs:134:28
[01:04:49]     |
[01:04:49] 134 |                 return Err(io::Error::new(io::ErrorKind::InvalidInput,
[01:04:49]     |                            ^^ Use of undeclared type or module `io`
[01:04:49] 
[01:04:49] error[E0433]: failed to resolve. Use of undeclared type or module `io`
[01:04:49]    --> libstd/sys/redox/net/tcp.rs:134:43
[01:04:49]     |
[01:04:49] 134 |                 return Err(io::Error::new(io::ErrorKind::InvalidInput,
[01:04:49]     |                                           ^^ Use of undeclared type or module `io`
[01:04:49] 
[01:04:49] error[E0433]: failed to resolve. Use of undeclared type or module `io`
[01:04:49]    --> libstd/sys/redox/net/tcp.rs:151:28
[01:04:49]     |
[01:04:49] 151 |                 return Err(io::Error::new(io::ErrorKind::InvalidInput,
[01:04:49]     |                            ^^ Use of undeclared type or module `io`
[01:04:49] 
[01:04:49] error[E0433]: failed to resolve. Use of undeclared type or module `io`
[01:04:49]    --> libstd/sys/redox/net/tcp.rs:151:43
[01:04:49]     |
[01:04:49] 151 |                 return Err(io::Error::new(io::ErrorKind::InvalidInput,
[01:04:49]     |                                           ^^ Use of undeclared type or module `io`
[01:04:49] 
[01:04:49] error[E0433]: failed to resolve. Use of undeclared type or module `io`
[01:04:49]    --> libstd/sys/redox/net/udp.rs:183:28
[01:04:49]     |
[01:04:49] 183 |                 return Err(io::Error::new(io::ErrorKind::InvalidInput,
[01:04:49]     |                            ^^ Use of undeclared type or module `io`
[01:04:49] 
[01:04:49] error[E0433]: failed to resolve. Use of undeclared type or module `io`
[01:04:49]    --> libstd/sys/redox/net/udp.rs:183:43
[01:04:49]     |
[01:04:49] 183 |                 return Err(io::Error::new(io::ErrorKind::InvalidInput,
[01:04:49]     |                                           ^^ Use of undeclared type or module `io`
[01:04:49] 
[01:04:49] error[E0433]: failed to resolve. Use of undeclared type or module `io`
[01:04:49]    --> libstd/sys/redox/net/udp.rs:200:28
[01:04:49]     |
[01:04:49] 200 |                 return Err(io::Error::new(io::ErrorKind::InvalidInput,
[01:04:49]     |                            ^^ Use of undeclared type or module `io`
[01:04:49] 
[01:04:49] error[E0433]: failed to resolve. Use of undeclared type or module `io`
[01:04:49]    --> libstd/sys/redox/net/udp.rs:200:43
[01:04:49]     |
[01:04:49] 200 |                 return Err(io::Error::new(io::ErrorKind::InvalidInput,
[01:04:49]     |                                           ^^ Use of undeclared type or module `io`
[01:04:49] 
[01:04:49] error[E0425]: cannot find value `dur` in this scope
[01:04:49]    --> libstd/sys/redox/net/tcp.rs:133:16
[01:04:49]     |
[01:04:49] 133 |             if dur.as_secs() == 0 && dur.subsec_nanos() == 0 {
[01:04:49]     |                ^^^ not found in this scope
[01:04:49] 
[01:04:49] error[E0425]: cannot find value `dur` in this scope
[01:04:49]    --> libstd/sys/redox/net/tcp.rs:133:38
[01:04:49]     |
[01:04:49] 133 |             if dur.as_secs() == 0 && dur.subsec_nanos() == 0 {
[01:04:49]     |                                      ^^^ not found in this scope
[01:04:49] 
[01:04:49] error[E0425]: cannot find value `dur` in this scope
[01:04:49]    --> libstd/sys/redox/net/tcp.rs:150:16
[01:04:49]     |
[01:04:49] 150 |             if dur.as_secs() == 0 && dur.subsec_nanos() == 0 {
[01:04:49]     |                ^^^ not found in this scope
[01:04:49] 
[01:04:49] error[E0425]: cannot find value `dur` in this scope
[01:04:49]    --> libstd/sys/redox/net/tcp.rs:150:38
[01:04:49]     |
[01:04:49] 150 |             if dur.as_secs() == 0 && dur.subsec_nanos() == 0 {
[01:04:49]     |                                      ^^^ not found in this scope
[01:04:49] 
[01:04:49] error[E0425]: cannot find value `dur` in this scope
[01:04:49]    --> libstd/sys/redox/net/udp.rs:182:16
[01:04:49]     |
[01:04:49] 182 |             if dur.as_secs() == 0 && dur.subsec_nanos() == 0 {
[01:04:49]     |                ^^^ not found in this scope
[01:04:49] 
[01:04:49] error[E0425]: cannot find value `dur` in this scope
[01:04:49]    --> libstd/sys/redox/net/udp.rs:182:38
[01:04:49]     |
[01:04:49] 182 |             if dur.as_secs() == 0 && dur.subsec_nanos() == 0 {
[01:04:49]     |                                      ^^^ not found in this scope
[01:04:49] 
[01:04:49] error[E0425]: cannot find value `dur` in this scope
[01:04:49]    --> libstd/sys/redox/net/udp.rs:199:16
[01:04:49]     |
[01:04:49] 199 |             if dur.as_secs() == 0 && dur.subsec_nanos() == 0 {
[01:04:49]     |                ^^^ not found in this scope
[01:04:49] 
[01:04:49] error[E0425]: cannot find value `dur` in this scope
[01:04:49]    --> libstd/sys/redox/net/udp.rs:199:38
[01:04:49]     |
[01:04:49] 199 |             if dur.as_secs() == 0 && dur.subsec_nanos() == 0 {
[01:04:49]     |                                      ^^^ not found in this scope
[01:04:49] 
[01:04:51] error: aborting due to 16 previous errors
[01:04:51] 
[01:04:51] error: Could not compile `std`.

frewsxcv · 2018-02-25T13:59:57Z

redox compile errors fixed 🔨 👷

@bors r=sfackler

bors · 2018-02-25T13:59:58Z

📌 Commit a554a2f has been approved by sfackler

…on, r=sfackler Add tests ensuring zero-Duration timeouts result in errors; fix Redox issues. Part of rust-lang#48311

Rollup of 17 pull requests - Successful merges: #47964, #47970, #48076, #48115, #48166, #48281, #48297, #48302, #48362, #48369, #48489, #48491, #48494, #48517, #48529, #48235, #48330 - Failed merges:

rust-highfive assigned TimNN Feb 18, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2018

frewsxcv force-pushed the frewsxcv-tests-zero-duration branch 3 times, most recently from c01582e to 2db8a7d Compare February 19, 2018 01:22

Add tests ensuring zero-Duration timeouts result in errors.

d17d645

Part of rust-lang#48311

frewsxcv force-pushed the frewsxcv-tests-zero-duration branch from 2db8a7d to d17d645 Compare February 19, 2018 02:42

frewsxcv changed the title ~~Add tests ensuring zero-Duration timeouts result in errors.~~ Add tests ensuring zero-Duration timeouts result in errors; fix Redox issues. Feb 19, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 20, 2018

Manishearth mentioned this pull request Feb 25, 2018

Rollup of 9 pull requests #48526

Closed

kennytm mentioned this pull request Feb 25, 2018

Rollup of 17 pull requests #48531

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2018

Return error if timeout is zero-Duration on Redox.

a554a2f

frewsxcv force-pushed the frewsxcv-tests-zero-duration branch from 0755825 to a554a2f Compare February 25, 2018 13:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2018

kennytm added a commit to kennytm/rust that referenced this pull request Feb 25, 2018

Rollup merge of rust-lang#48330 - frewsxcv:frewsxcv-tests-zero-durati…

1aa1035

…on, r=sfackler Add tests ensuring zero-Duration timeouts result in errors; fix Redox issues. Part of rust-lang#48311

bors merged commit a554a2f into rust-lang:master Feb 25, 2018

frewsxcv mentioned this pull request Mar 3, 2018

Strengthen/clarify "It is an error to..." wording #48311

Closed

Uh oh!

Conversation

frewsxcv commented Feb 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frewsxcv commented Feb 18, 2018

Uh oh!

rust-highfive commented Feb 18, 2018

Uh oh!

bors commented Feb 18, 2018

Uh oh!

bors commented Feb 18, 2018

Uh oh!

frewsxcv commented Feb 19, 2018

Uh oh!

bors commented Feb 19, 2018

Uh oh!

frewsxcv commented Feb 19, 2018

Uh oh!

bors commented Feb 19, 2018

Uh oh!

bors commented Feb 19, 2018

Uh oh!

frewsxcv commented Feb 19, 2018

Uh oh!

sfackler commented Feb 20, 2018

Uh oh!

bors commented Feb 20, 2018

Uh oh!

kennytm commented Feb 25, 2018

Uh oh!

frewsxcv commented Feb 25, 2018

Uh oh!

bors commented Feb 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

frewsxcv commented Feb 18, 2018 •

edited

Loading