Use `dyn trait` everywhere#48477

Manishearth · 2018-02-23T18:31:15Z

Based on #48461

do not land unless both are reviewed.

rust-highfive · 2018-02-23T18:31:17Z

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

Manishearth · 2018-02-23T18:31:52Z

r? @nikomatsakis

nikomatsakis · 2018-03-02T22:44:50Z

src/librustc_mir/transform/mod.rs

        };
        let mut index = 0;
-        let mut run_pass = |pass: &dyn MirPassPassPass| {
+        let mut run_pass = |pass: &dyn MirPass| {


what's up with these fixups?

Macros are involved and rustfix broke. There's a bug filed for this.

nikomatsakis · 2018-03-02T22:45:00Z

src/librustc_mir/borrow_check/nll/explain_borrow/mod.rs

    }

-    fn def_use(&self, location: Location, thing: &MirVisitable<'tcx>) -> (bool, bool) {
+    fn def_use(&self, location: Location, thing: &dyn MirVisitable<'tcx>) -> (bool, bool) {


this was all automated, right?

nikomatsakis · 2018-03-02T22:45:43Z

@Manishearth r=me, but i'd like to know to what extent this was done automatically with rustfix (the commit names suggest it was), and what drove the need for the fixups -- do those represent bugs in the compiler suggestions?

Manishearth · 2018-03-02T23:14:31Z

It's because of macros; we should be using the non-machine-applicable flag when macros are involved, and/or make rustfix better at this.

In these cases rustfix would be able to help if it understood when multiple suggestions are the same textual suggestion (there's a bug filed)

Manishearth · 2018-03-02T23:14:51Z

@bors r=nmatsakis

The commits with "rustfix" in their message were automated, fwiw

bors · 2018-03-02T23:14:52Z

📌 Commit 38676c6 has been approved by nmatsakis

Manishearth · 2018-03-03T01:51:44Z

@bors p=2

potential to bitrot since it's a major lint

…sakis Use `dyn trait` everywhere Based on rust-lang#48461 do not land unless both are reviewed.

bors · 2018-03-03T04:58:26Z

☔ The latest upstream changes (presumably #48586) made this pull request unmergeable. Please resolve the merge conflicts.

Manishearth · 2018-03-03T05:03:06Z

@bors r=nmatsakis

bors · 2018-03-03T05:03:07Z

📌 Commit 40f218f has been approved by nmatsakis

@nrc

…sakis Fixes rust-lang#47311. r? @nrc

zengsai · 2018-03-08T03:38:09Z

Is there any plan to make "Use impl trait everywhere"?

Manishearth · 2018-03-08T03:48:22Z

Nope. Dyn trait is an alternate, preferred syntax over bare trait objects. Impl trait is a new syntax that can replace some things but it's really its own thing with its own effects on APIs ७ मार्च, २०१८ ७:३८ म.उ. रोजी, "Sai Zeng" <notifications@github.com> ने लिहिले:

…

Is there any pan to make "Use impl trait everywhere"? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#48477 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABivSE68h43KQX_rnbDfnwJUJTO9fBJQks5tcKe2gaJpZM4SRSrn> .

rust-highfive assigned petrochenkov Feb 23, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2018

Manishearth mentioned this pull request Feb 23, 2018

Add functionality for epoch lints; add epoch lint for dyn-trait #48461

Merged

rust-highfive assigned nikomatsakis and unassigned petrochenkov Feb 23, 2018

Manishearth force-pushed the dyn-trait-fixes branch 2 times, most recently from c1c4699 to 38676c6 Compare March 1, 2018 04:51

nikomatsakis approved these changes Mar 2, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2018

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 3, 2018

Rollup merge of rust-lang#48477 - Manishearth:dyn-trait-fixes, r=nmat…

d54cf1b

…sakis Use `dyn trait` everywhere Based on rust-lang#48461 do not land unless both are reviewed.

Manishearth mentioned this pull request Mar 3, 2018

Rollup of 8 pull requests #48687

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2018

Manishearth added 6 commits March 2, 2018 21:02

Run Rustfix on librustc

69c53ac

Perform manual fixups

f3cb962

Remove allow(bare_trait_object) from librustc

fb7980d

Run Rustfix on librustc_mir

8d730ed

Perform manual fixups

3c95814

Remove allow(bare_trait_object) from librustc_mir

40f218f

Manishearth force-pushed the dyn-trait-fixes branch from 38676c6 to 40f218f Compare March 3, 2018 05:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2018

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 3, 2018

Rollup merge of rust-lang#48477 - Manishearth:dyn-trait-fixes, r=nmat…

85a6b92

…sakis Fixes rust-lang#47311. r? @nrc

bors merged commit 40f218f into rust-lang:master Mar 3, 2018

Uh oh!

Conversation

Manishearth commented Feb 23, 2018

Uh oh!

rust-highfive commented Feb 23, 2018

Uh oh!

Manishearth commented Feb 23, 2018

Uh oh!

nikomatsakis Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

Manishearth Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

nikomatsakis Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

Manishearth Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented Mar 2, 2018

Uh oh!

Manishearth commented Mar 2, 2018

Uh oh!

Manishearth commented Mar 2, 2018

Uh oh!

bors commented Mar 2, 2018

Uh oh!

Manishearth commented Mar 3, 2018

Uh oh!

bors commented Mar 3, 2018

Uh oh!

Manishearth commented Mar 3, 2018

Uh oh!

bors commented Mar 3, 2018

Uh oh!

zengsai commented Mar 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Manishearth commented Mar 8, 2018 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zengsai commented Mar 8, 2018 •

edited

Loading