Revert "correct subtle bug in the type variable code"#48666
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 3, 2018
Merged
Revert "correct subtle bug in the type variable code"#48666bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
This reverts commit ccd92c2. This commit is the source of a major perf regression, and was not intended to be included in rust-lang#47861. At some point I must have accidentally re-added the commit.
Contributor
Author
|
/cc @Mark-Simulacrum @rust-lang/release needs perf |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
@bors r+ p=1 -- this corrects a major perf regression. We already know that it has a big impact since we measured before, let's just land and observe the effect. |
Collaborator
|
📌 Commit f5f53e9 has been approved by |
bors
added
S-waiting-on-bors
Member
|
@bors p=5 Because everything else is currently p=2 😄 |
Member
|
@bors p=50 |
Collaborator
bors
added a commit
that referenced
this pull request
Mar 3, 2018
Revert "correct subtle bug in the type variable code" This reverts commit ccd92c2. This commit is the source of a major perf regression, and was not intended to be included in #47861. At some point I must have accidentally re-added the commit. Fixes #48660. r? @nikomatsakis
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Contributor
Author
|
Thanks for the p bump @kennytm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ccd92c2.
This commit is the source of a major perf regression, and was not
intended to be included in #47861. At some point I must have
accidentally re-added the commit.
Fixes #48660.
r? @nikomatsakis