Stabilize option_ref_mut_cloned#48787

mbrubeck · 2018-03-06T18:36:51Z

Closes #43738.

rust-highfive · 2018-03-06T18:37:01Z

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

joshtriplett · 2018-03-06T20:10:05Z

@bors r+

bors · 2018-03-06T20:10:07Z

📌 Commit 0539613 has been approved by joshtriplett

Aaron1011 · 2018-03-06T22:38:59Z

The doc comment for that function still contains the #[feature] attribute, under the Examples heading:

     /// #![feature(option_ref_mut_cloned)]
     /// let mut x = 12;

Since the feature is being stabilized, I believe that should be removed.

Closes rust-lang#43738.

mbrubeck · 2018-03-06T22:41:21Z

The doc comment for that function still contains the #[feature] attribute

Fixed, thanks. r? @joshtriplett

joshtriplett · 2018-03-06T23:00:43Z

Good catch, thank you!

joshtriplett · 2018-03-06T23:00:49Z

@bors r+

bors · 2018-03-06T23:00:50Z

📌 Commit d04362f has been approved by joshtriplett

alexcrichton · 2018-03-07T01:55:47Z

@bors: rollup

Stabilize option_ref_mut_cloned Closes rust-lang#43738.

Rollup of 9 pull requests - Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802 - Failed merges: #48669, #48710

Stabilize option_ref_mut_cloned Closes rust-lang#43738.

Rollup of 9 pull requests - Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802 - Failed merges: #48669, #48710

rust-highfive assigned joshtriplett Mar 6, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2018

joshtriplett approved these changes Mar 6, 2018

View reviewed changes

kennytm added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 6, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2018

Stabilize option_ref_mut_cloned

d04362f

Closes rust-lang#43738.

mbrubeck force-pushed the cloned branch from 0539613 to d04362f Compare March 6, 2018 22:40

Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 7, 2018

alexcrichton mentioned this pull request Mar 7, 2018

Rollup of 9 pull requests #48806

Merged

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 7, 2018

Rollup merge of rust-lang#48787 - mbrubeck:cloned, r=joshtriplett

2e9f960

Stabilize option_ref_mut_cloned Closes rust-lang#43738.

bors added a commit that referenced this pull request Mar 7, 2018

Auto merge of #48806 - alexcrichton:rollup, r=alexcrichton

6675913

Rollup of 9 pull requests - Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802 - Failed merges: #48669, #48710

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 7, 2018

Rollup merge of rust-lang#48787 - mbrubeck:cloned, r=joshtriplett

05ebc19

Stabilize option_ref_mut_cloned Closes rust-lang#43738.

bors added a commit that referenced this pull request Mar 7, 2018

Auto merge of #48806 - alexcrichton:rollup, r=alexcrichton

29d7fc1

Rollup of 9 pull requests - Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802 - Failed merges: #48669, #48710

bors added a commit that referenced this pull request Mar 7, 2018

Auto merge of #48806 - alexcrichton:rollup, r=alexcrichton

5430c0c

Rollup of 9 pull requests - Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802 - Failed merges: #48669, #48710

alexcrichton merged commit d04362f into rust-lang:master Mar 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stabilize option_ref_mut_cloned#48787