Unstabilize FusedIterator for Flatten since Flatten is unstable#49049
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 16, 2018
Merged
Unstabilize FusedIterator for Flatten since Flatten is unstable#49049bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Centril
added
the
T-libs-api
rust-highfive
added
the
S-waiting-on-review
Contributor
|
I'm confused. impls don't really have stability anyway (there are annotations but they're not enforced), and besides, if the type is unstable, how could the impl "leak" into stable code? |
Contributor
Author
|
@rkruppe as I understand it, this PR won't really change anything, so it is mostly for consistency with #47463 (review) and documentation (so that users see that At some point maybe we should consider enforcing stability on impls... |
Contributor
|
@bors r+ rollup Thanks, this makes sense even if it's just for docs |
Collaborator
|
📌 Commit 6fbdaf4 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 15, 2018
…r=bluss Unstabilize FusedIterator for Flatten since Flatten is unstable PR rust-lang#47463 made `impl<I, U> FusedIterator for Flatten<I>` stable but shouldn't have since `Flatten` is still unstable. This PR makes the impl unstable again.
bors
added a commit
that referenced
this pull request
Mar 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #47463 made
impl<I, U> FusedIterator for Flatten<I>stable but shouldn't have sinceFlattenis still unstable. This PR makes the impl unstable again.r? @bluss
cc @alexcrichton