Reduce the diagnostic spam when multiple fields are missing in pattern#49160
Merged
alexcrichton merged 3 commits intorust-lang:masterfrom Mar 23, 2018
Merged
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
changed the title
oli-obk
requested changes
Mar 19, 2018
Contributor
There was a problem hiding this comment.
did you forget to generate or git add a .stderr file?
src/librustc_typeck/check/_match.rs
Outdated
Contributor
There was a problem hiding this comment.
I think the labels could just be unknown field instead of repeating all information
Contributor
There was a problem hiding this comment.
or, since these are usually very compact, do something similar to use imports:
warning: unused imports: `u32`, `usize`
--> src/main.rs:1:11
|
1 | use std::{usize, u32};
| ^^^^^ ^^^
estebank
force-pushed
the
issue-47457-missing-fields
branch
3 times, most recently
from
3fff16c to
97cf809
Compare
estebank
force-pushed
the
issue-47457-missing-fields
branch
5 times, most recently
from
16987ae to
0d6ba1d
Compare
estebank
force-pushed
the
issue-47457-missing-fields
branch
from
0d6ba1d to
062a46f
Compare
Contributor
|
@bors r+ Looks sooo much better than the old spammy messages! |
Collaborator
|
📌 Commit 062a46f has been approved by |
bors
added
S-waiting-on-bors
oli-obk
approved these changes
Mar 20, 2018
Contributor
Author
|
@bors rollup |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 23, 2018
…, r=oli-obk Reduce the diagnostic spam when multiple fields are missing in pattern Fix rust-lang#47457.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 23, 2018
…, r=oli-obk Reduce the diagnostic spam when multiple fields are missing in pattern Fix rust-lang#47457.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2018
…, r=oli-obk Reduce the diagnostic spam when multiple fields are missing in pattern Fix rust-lang#47457.
bors
added a commit
that referenced
this pull request
Mar 23, 2018
Collaborator
|
☔ The latest upstream changes (presumably #49308) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #47457.