Skip to content

Put #[macro_use] extern crate <crate> before fn main() in doctests#49188

Merged
alexcrichton merged 1 commit intorust-lang:masterfrom
memoryleak47:macro_use_doctest
Mar 22, 2018
Merged

Put #[macro_use] extern crate <crate> before fn main() in doctests#49188
alexcrichton merged 1 commit intorust-lang:masterfrom
memoryleak47:macro_use_doctest

Conversation

@memoryleak47
Copy link
Contributor

@memoryleak47 memoryleak47 commented Mar 19, 2018

Closes #49174.

@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 19, 2018

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2018
@QuietMisdreavus
Copy link
Contributor

QuietMisdreavus commented Mar 19, 2018

Looks good! Thanks for picking this up this fast. I'm gonna wait and see if Travis picks up anything we didn't think of, then push this on through.

@QuietMisdreavus
Copy link
Contributor

QuietMisdreavus commented Mar 20, 2018

@bors r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Mar 20, 2018

📌 Commit 25c8210 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018
@kennytm kennytm mentioned this pull request Mar 21, 2018
Closed
@kennytm kennytm mentioned this pull request Mar 21, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 21, 2018
@kennytm
Rollup merge of rust-lang#49188 - memoryleak47:macro_use_doctest, r=Q…
b199613 
…uietMisdreavus

Put `#[macro_use] extern crate <crate>` before fn main() in doctests

Closes rust-lang#49174.
@kennytm kennytm mentioned this pull request Mar 22, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 22, 2018
@kennytm
Rollup merge of rust-lang#49188 - memoryleak47:macro_use_doctest, r=Q…
95967c7 
…uietMisdreavus

Put `#[macro_use] extern crate <crate>` before fn main() in doctests

Closes rust-lang#49174.
bors added a commit that referenced this pull request Mar 22, 2018
@bors
Auto merge of #49264 - kennytm:rollup, r=kennytm
5092c6b 
Rollup of 23 pull requests

- Successful merges: #48374, #48596, #48759, #48939, #49029, #49069, #49093, #49109, #49117, #49140, #49158, #49188, #49189, #49209, #49211, #49216, #49225, #49231, #49234, #49242, #49244, #49105, #49038
- Failed merges:
@alexcrichton alexcrichton merged commit 25c8210 into rust-lang:master Mar 22, 2018
@memoryleak47 memoryleak47 deleted the macro_use_doctest branch April 6, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabnik steveklabnik

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@memoryleak47 @rust-highfive @QuietMisdreavus @bors @steveklabnik @alexcrichton