Document format_args! / Arguments<'a> behavior wrt. Display and Debug#49229
Merged
bors merged 3 commits intorust-lang:masterfrom Mar 24, 2018
Merged
Document format_args! / Arguments<'a> behavior wrt. Display and Debug#49229bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
Centril
added
the
A-docs
rust-highfive
added
the
S-waiting-on-review
Centril
added
the
C-enhancement
steveklabnik
suggested changes
Mar 21, 2018
Contributor
steveklabnik
left a comment
steveklabnik
left a comment
There was a problem hiding this comment.
I think this looks good to me, thanks! travis is failing due to the trailing whitespace though. r=me once it's green
src/libcore/fmt/mod.rs
Outdated
| /// | ||
| /// struct Arm<'a, L: 'a, R: 'a>(&'a (L, R)); | ||
| /// struct Table<'a, K: 'a, V: 'a>(&'a [(K, V)], V); | ||
| /// |
Contributor
There was a problem hiding this comment.
you've got trailing whitespace here
Contributor
Author
There was a problem hiding this comment.
How embarrassing; should have run tidy ^,- I'll fix this sometime tonight =)
Contributor
Author
steveklabnik
approved these changes
Mar 24, 2018
Contributor
|
@bors: r+ rollup |
Collaborator
|
📌 Commit 613fb8b has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 24, 2018
…ug, r=steveklabnik Document format_args! / Arguments<'a> behavior wrt. Display and Debug This is a follow up PR to rust-lang#49067 , this documents the behavior of `format_args!` (i.e: `Argument<'a>`) wrt. `Display` and `Debug`.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 24, 2018
…ug, r=steveklabnik Document format_args! / Arguments<'a> behavior wrt. Display and Debug This is a follow up PR to rust-lang#49067 , this documents the behavior of `format_args!` (i.e: `Argument<'a>`) wrt. `Display` and `Debug`. r? @steveklabnik
bors
added a commit
that referenced
this pull request
Mar 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to #49067 , this documents the behavior of
format_args!(i.e:Argument<'a>) wrt.DisplayandDebug.r? @steveklabnik