Remove unneeded trait implementations titles#49335
Conversation
rust-highfive
added
the
S-waiting-on-review
There was a problem hiding this comment.
Is the "implementations" being lowercase here going to cause a problem? I remember in the past we had a misspelled string in a @!has rule, which is always going to be false, but i don't remember whether the htmldocck.py check is case-sensitive.
There was a problem hiding this comment.
It is case sensitive (which caused me a few issues).
There was a problem hiding this comment.
It looks like the real header capitalizes the "I" there, so that should be changed.
GuillaumeGomez
force-pushed
the
remove-unneeded-trait-implementations-title
branch
from
b7b6eff to
dc2ec23
Compare
|
Updated, let's see if it still works. :) |
GuillaumeGomez
force-pushed
the
remove-unneeded-trait-implementations-title
branch
from
dc2ec23 to
d91a821
Compare
|
Test failed because there is "Auto Trait Implementations", which matches what we were looking for. |
|
Aha! In that case, i've seen other tests have luck using |
|
Open an issue for them. :p |
|
📌 Commit d91a821 has been approved by |
bors
added
S-waiting-on-bors
…ations-title, r=QuietMisdreavus Remove unneeded trait implementations titles r? @QuietMisdreavus
|
☀️ Test successful - status-appveyor, status-travis |
4 participants
r? @QuietMisdreavus