Don't inject clippy into rls on stable/beta#49876
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 14, 2018
Hidden character warning
The head ref may contain hidden characters: "no_secret_clippy_on_stable_\u2639"
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
kennytm
added
the
beta-nominated
Member
|
@bors: r+ We'd normally discuss the beta request at a meeting, but this seems obviously a good thing to uplift, so beta approving too. |
Collaborator
|
📌 Commit 34956c8 has been approved by |
bors
added
S-waiting-on-bors
nrc
added
the
beta-accepted
Contributor
Author
|
Is the rls-preview component available on beta/stable? If not, there's no need to backport |
Member
It is |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Apr 13, 2018
…☹, r=nrc Don't inject clippy into rls on stable/beta r? @nrc as discussed at the all-hands
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Apr 14, 2018
…☹, r=nrc Don't inject clippy into rls on stable/beta as discussed at the all-hands
oli-obk
removed
beta-accepted
kennytm
added
the
beta-accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @nrc
as discussed at the all-hands