Clean up IsolatedEncoder::encode_info_for_impl_item() a bit#50129
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 23, 2018
Merged
Clean up IsolatedEncoder::encode_info_for_impl_item() a bit#50129bors merged 1 commit intorust-lang:masterfrom
IsolatedEncoder::encode_info_for_impl_item() a bit#50129bors merged 1 commit intorust-lang:masterfrom
Conversation
emilyalbini
added
the
S-waiting-on-review
Member
|
Assigned the same reviewer of the other PR, @michaelwoerister. |
Member
|
@bors r+ Thanks for following up on that, @wesleywiser! |
Collaborator
|
📌 Commit 732cc73 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Apr 23, 2018
Clean up `IsolatedEncoder::encode_info_for_impl_item()` a bit Suggested in the [comments of #49991](https://github.com/rust-lang/rust/pull/49991/files/4a77d35c1ed89310a0ed128ce931cd4b85ca4cd4#r183048939)
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested in the comments of #49991