Fix rustdoc pathes search

[GuillaumeGomez]

Fixes #50086.

Depends on #50302.

r? @QuietMisdreavus

[QuietMisdreavus]

I'm confused why you added the exact-check flag but didn't actually use it.

Also, now that #50302 is merged, can you rebase to filter that commit out of this PR?

[GuillaumeGomez]

I'm confused why you added the exact-check flag but didn't actually use it.

Good catch! I now use it in the pinbox test. :)

[QuietMisdreavus]

Note to self when the new exact-check flag is added to rustc-guide: The difference between setting exact-check and not setting ignore-order is that "no flags" only means that the actual results include the expected results in the right order, but exact-check ensures that no additional items are in the actual result. In other words, the actual result is exactly the same as the input.

[QuietMisdreavus]

Okay, after a bit of a chat to piece together what's going on, i'm okay with this. The key takeaway is that the conditional being changed was being used to short-circuit any query which matched the input, regardless of whether it was part of a longer path. The added conditional makes it so that this branch only gets hit on queries that don't have a :: in it. That makes it so that other sorters come in to order the results, thus putting std::vec::Vec::new back on top when you're searching for vec::new.

@bors r+ rollup

[bors]

📌 Commit 2bfbe55 has been approved by QuietMisdreavus

[kennytm]

@bors r-

Checking "pinbox-new.js" ... FAILED
==> Exact check failed at position 1: expected '{"path":"std::boxed::PinBox","name":"new"}' but found '{"crate":"std","ty":11,"name":"new","path":"std::boxed","desc":"Allocate memory on the heap, move the data into it and pin it.","parent":{"ty":3,"name":"PinBox"},"type":{"inputs":[{"name":"t"}],"output":{"name":"pinbox"}},"lev":1}'

[GuillaumeGomez]

Fixed.

[QuietMisdreavus]

Since the travis builder doesn't have node, we won't know whether this works until bors gets its hands on it.

@bors r+ rollup-

[bors]

📌 Commit 2c91b49 has been approved by QuietMisdreavus

[bors]

⌛ Testing commit 2c91b49 with merge c8a3ec1...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing c8a3ec1 to master...