Prevent main from having a where clause.#50782
Merged
bors merged 1 commit intorust-lang:masterfrom May 19, 2018
Merged
Conversation
Contributor
|
You should add this check for rust/src/librustc_typeck/lib.rs Lines 251 to 258 in 27acb9b |
Contributor
|
So, this cannot affect libraries, so the potential impact is pretty limited. I suspect we can get by without a crater run. |
Contributor
Collaborator
|
✌️ @matthewjasper can now approve this pull request |
dc6ae8b to
7706649
Compare
varkor
reviewed
May 18, 2018
src/librustc_typeck/diagnostics.rs
Outdated
Contributor
There was a problem hiding this comment.
Your tests look correct, but this isn't a correct example of a start function.
7706649 to
27acb9b
Compare
Contributor
Author
|
@bors r+ |
Collaborator
|
📌 Commit 218a81b has been approved by |
Member
|
@bors p=4 |
Collaborator
bors
added a commit
that referenced
this pull request
May 19, 2018
Prevent main from having a where clause. Closes #50714 Should this have a crater run? cc #48557, #48214 r? @nikomatsakis
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50714
Should this have a crater run?
cc #48557, #48214
r? @nikomatsakis