Add documentation about env! second argument#51014
Conversation
rust-highfive
added
the
S-waiting-on-review
QuietMisdreavus
left a comment
QuietMisdreavus
left a comment
There was a problem hiding this comment.
This is a little too informal for my tastes. Here are some suggestions.
I'm a little cautious about the specific error message you used, too, but i think i'll let that fly.
src/libstd/macros.rs
Outdated
There was a problem hiding this comment.
"You can customize the error message by passing a string as the second parameter:"
src/libstd/macros.rs
Outdated
There was a problem hiding this comment.
"If the documentation environment variable is not defined, you'll get the following error:"
src/libstd/macros.rs
Outdated
There was a problem hiding this comment.
I think "error" should be all-caps here; isn't that how the compiler outputs it?
There was a problem hiding this comment.
I copied/pasted the compiler output so apparently no...
There was a problem hiding this comment.
Oh, well in that case we can leave it, lol.
|
Updated. |
|
Thanks so much! r=me pending travis. |
|
@bors r+ rollup |
|
📌 Commit fe9a195 has been approved by |
bors
added
S-waiting-on-bors
…dreavus Add documentation about env! second argument Fixes rust-lang#48044. r? @QuietMisdreavus
Rollup of 11 pull requests Successful merges: - #50987 (Underline multiple suggested replacements in the same line) - #51014 (Add documentation about env! second argument) - #51034 (Remove unused lowering field and method) - #51047 (Use AllFacts from polonius-engine) - #51048 (Add more missing examples for Formatter) - #51056 (Mention and use `Once::new` instead of `ONCE_INIT`) - #51059 (What does an expression look like, that consists only of special characters?) - #51065 (Update nomicon link in transmute docs) - #51067 (Add inner links in documentation) - #51070 (Fail typecheck if we encounter a bogus break) - #51073 (Rename TokenStream::empty to TokenStream::new) Failed merges:
4 participants
Fixes #48044.
r? @QuietMisdreavus