also check let arms and nested patterns for mutable borrows#51274
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 2, 2018
Merged
also check let arms and nested patterns for mutable borrows#51274bors merged 1 commit intorust-lang:masterfrom
let arms and nested patterns for mutable borrows#51274bors merged 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
oh, let me bless the test. =) |
Member
|
Should we backport this to beta since it does fix unsoundness? |
Contributor
Author
|
Fixed tests. |
nikomatsakis
force-pushed
the
issue-46557-promote-ref-mut
branch
from
4d932a9 to
a667049
Compare
Contributor
Author
|
@Mark-Simulacrum we could .. it's not a recent regression or anything though. |
Contributor
Author
|
OTOH it's a small patch and I believe the code is pretty old, would be a low-risk backport |
oli-obk
added
the
beta-nominated
Merged
Member
|
I hate the old borrowck, at this point it's an incoherent mess of recursive fine-prints. @bors r+ p=10 |
Collaborator
|
📌 Commit a667049 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
emilyalbini
added
the
T-compiler
Contributor
Author
|
We could backport this, but there's no burning reason to do so. Clearing the backport flag. |
nikomatsakis
removed
the
beta-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46557
r? @eddyb