Improve unstable feature message display#51563
Closed
GuillaumeGomez wants to merge 1 commit intorust-lang:masterfrom
Closed
Improve unstable feature message display#51563GuillaumeGomez wants to merge 1 commit intorust-lang:masterfrom
GuillaumeGomez wants to merge 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Member
|
Ping from triage @QuietMisdreavus! This PR needs your review. |
Member
Author
|
I need to modify it again after a discussion we had (putting the unstable message into the doc instead). |
emilyalbini
added
S-waiting-on-author
Member
|
Ping from triage @GuillaumeGomez! It's been a while since we heard from you, will you have time to work on this again? |
Member
Author
|
I'll, just going through my TODO list by thanks for the reminder. :) |
Contributor
|
Ping from triage, @GuillaumeGomez! |
Contributor
|
Ping from triage, @GuillaumeGomez! We haven't heard from you in a while, so we are closing this PR. Feel free to re-open it in the future. Thanks for your contribution! |
TimNN
added
S-inactive
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 26, 2018
…-display, r=QuietMisdreavus Improve unstable message display Fixes rust-lang#51387. Reopening of rust-lang#51563. New display: <img width="1440" alt="screen shot 2018-08-04 at 00 01 39" src="https://user-images.githubusercontent.com/3050060/43667793-dc14f708-9779-11e8-9808-f3ff126fc213.png"> r? @QuietMisdreavus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51387.
r? @QuietMisdreavus