use the adjusted type for cat_pattern in tuple patterns #52232
Merged
bors merged 3 commits intorust-lang:masterfrom Jul 11, 2018
Merged
use the adjusted type for cat_pattern in tuple patterns #52232bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
This looks like a typo introduced in rust-lang#51686. Fixes rust-lang#52213.
I don't see why MC should fail on well-formed code, so it might be a better idea to just add a `delay_span_bug` there (anyone remember the `cat_expr Errd` bug from the 1.0 days?). However, I don't think this is a good idea to backport a new delay_span_bug into stable and this code is going away soon-ish anyway.
arielb1
added
beta-nominated
rust-highfive
added
the
S-waiting-on-review
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 4c04453 has been approved by |
bors
added
S-waiting-on-bors
Member
|
@bors p=13 |
Collaborator
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
emilyalbini
added
the
T-compiler
Contributor
|
@rfcbot fcp merge I propose that we approve backporting this to beta. Since time is somewhat limited, and back ports are usually less controversial than the usual things that go through the fcp process, I'm going to add the additional note if there are no unresolved formal concerns in a week's time, I will just check off any unmarked check boxes. (This effectively inverts the rfcbot into "approved by default.") |
This was referenced Jul 12, 2018
emilyalbini
added
beta-accepted
Member
emilyalbini
removed
the
beta-nominated
Merged
bors
added a commit
that referenced
this pull request
Jul 18, 2018
1.27.2 stable release This is essentially a backport of #52232. I've set the release date for Friday, July 20th. r? @alexcrichton
Mark-Simulacrum
removed
the
stable-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks like a typo introduced in #51686.
Fixes #52213.
r? @pnkfelix
beta + stable nominating because regression + unsoundness.