Avoid unnecessary pattern matching against Option and Result#52773
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 9, 2018
Merged
Avoid unnecessary pattern matching against Option and Result#52773bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ljedrz
force-pushed
the
unncecessary_patterns
branch
from
963b8a8 to
f1dbdac
Compare
Contributor
Author
|
Rebased after 4c1cb75. |
Member
|
r? @nikomatsakis (some of these might be intentional) |
nikomatsakis
requested changes
Aug 6, 2018
Contributor
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
Seems fine apart from the one case, where the is_err is too easily overlooked
Contributor
There was a problem hiding this comment.
Nit: I'd prefer to see is_err on its own line here
Contributor
Author
There was a problem hiding this comment.
Sounds good, I'll update the commit soon.
ljedrz
force-pushed
the
unncecessary_patterns
branch
from
f1dbdac to
44d32d4
Compare
Contributor
Author
|
@nikomatsakis done. |
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 44d32d4 has been approved by |
bors
added
S-waiting-on-bors
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
…omatsakis Avoid unnecessary pattern matching against Option and Result
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
…omatsakis Avoid unnecessary pattern matching against Option and Result
This was referenced Aug 8, 2018
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
…omatsakis Avoid unnecessary pattern matching against Option and Result
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
…omatsakis Avoid unnecessary pattern matching against Option and Result
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 9, 2018
…omatsakis Avoid unnecessary pattern matching against Option and Result
bors
added a commit
that referenced
this pull request
Aug 9, 2018
Rollup of 15 pull requests Successful merges: - #52773 (Avoid unnecessary pattern matching against Option and Result) - #53082 (Fix doc link (again)) - #53094 (Automatically expand section if url id point to one of its component) - #53106 (atomic ordering docs) - #53110 (Account for --remap-path-prefix in save-analysis) - #53116 (NetBSD: fix signedess of char) - #53179 (Whitelist wasm32 simd128 target feature) - #53183 (Suggest comma when missing in macro call) - #53207 (Add individual docs for rotate_{left, right}) - #53211 ([nll] enable feature(nll) on various crates for bootstrap) - #53214 ([nll] enable feature(nll) on various crates for bootstrap: part 2) - #53215 (Slightly refactor syntax_ext/format) - #53217 (inline some short functions) - #53219 ([nll] enable feature(nll) on various crates for bootstrap: part 3) - #53222 (A few cleanups for rustc_target)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.