Updated RELEASES.md for 1.29.0#53030

XAMPPRocky · 2018-08-03T15:12:02Z

r? @Mark-Simulacrum
cc @rust-lang/release

phansch · 2018-08-03T15:18:19Z

Should this mention clippy-preview?

est31 · 2018-08-03T15:27:25Z

RELEASES.md

+-----
+- [Cargo can silently fix some bad lockfiles ][cargo/5831] You can use
+  `--locked` to disable this behaviour.
+- [`cargo-install` will now ignore the target triple specified in a project


Per this comment it seems like this was reverted again.

est31 · 2018-08-03T15:29:02Z

RELEASES.md

+  directory's `.cargo/config`.][cargo/5606]
+- [`cargo-install` will now allow you to cross compile an install
+  using `--target`][cargo/5614]
+- [Added the `cargo-fix` to automatically move project code from 2015 edition


You might add a noun somewhere like "subcommand" or "tool", like:

Added the cargo fix subcommand

kennytm · 2018-08-03T15:43:49Z

RELEASES.md

+
+Misc
+----
+- [`rustdoc` now has the `--cap-lints` which allows you to set what level of


rustdoc now has the --cap-lints

Remove the "the".

which allows you to set what level of lint will cause and compilation failure.

The purpose of cap-lints is to make all lints not exceeding the specified level. For instance, if we pass --cap-lints warn, then all lints with level deny or forbid will be demoted to warn.

Perhaps just express this flag being "equivalent to that in rustc".

kennytm · 2018-08-03T15:44:48Z

RELEASES.md

+----
+- [`rustdoc` now has the `--cap-lints` which allows you to set what level of
+  lint will cause and compilation failure.][52354]
+- [`rustc` and `rustdoc` will now have the exit code of one if compilation


I suggest writing "1" instead of "one" here...

kennytm · 2018-08-03T15:45:09Z

RELEASES.md

+-------------------
+- [`str::{slice_unchecked, slice_unchecked_mut}` are now deprecated.][51807]
+  Use `str::get_unchecked(begin..end)` instead.
+- [`std::env::home_dir` is now deprecated for it's unintuitive behaviour.][51656]


it's ↦ its

Mark-Simulacrum · 2018-08-03T16:28:09Z

Looks good to me, looks like there's a few other things we should add to it though (see comments above).

Havvy · 2018-08-03T19:44:43Z

~~Rc::downcast should link to std/rc/struct.Rc.html and not std/sync/struct.Rc.html.~~ Fixed now.

sgrif · 2018-08-04T00:03:34Z

RELEASES.md

+
+Compiler
+--------
+- [Bumped minimum LLVM version to 5.0.][51899]


Sorry if this is naive to ask -- but is this ever actually visible to users? Isn't LLVM vendored either way?

It's relevant to distros, so worth noting here I think.

Again, this is entirely me being uninformed, but if you have time do you mind explaining to me why it is relevant to distros? (If you don't have time or don't care to explain this I completely understand)

Since we've removed code from the LLVM shims that was needed for 4.9 (or whatever the previous version was, maybe 3.9) compatibility, distros that package that previous LLVM might need to do more work now. However, I believe that someone did a loose survey and we believe that most if not all distros are on 5.0+ already.

Isn't it vendored either way though?

You can build with your own external LLVM too, and distros usually do.

sgrif · 2018-08-04T00:05:40Z

RELEASES.md

+
+Libraries
+---------
+- [`Once::call_once` now no longer requires `Once` to be `'static`.][52239]


I'm not sure what this means. Are you referring to the closure being passed to call_once? Once is either 'static or not, it's not a generic type -- the user has no control over whether that type is 'static

Not the closure, previously call_once takes a &'static self.

What do you think about rephrasing this as "Once::call_once now takes &self instead of &'static self"?

Mark-Simulacrum · 2018-08-20T11:55:25Z

Let's get this landed, if necessary we can iterate further.

@bors r+ rollup

bors · 2018-08-20T11:55:26Z

📌 Commit b4924bf has been approved by Mark-Simulacrum

@Mark-Simulacrum

Updated RELEASES.md for 1.29.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md) r? @Mark-Simulacrum cc @rust-lang/release

@ghost

Rollup of 17 pull requests Successful merges: - #53030 (Updated RELEASES.md for 1.29.0) - #53104 (expand the documentation on the `Unpin` trait) - #53213 (Stabilize IP associated constants) - #53296 (When closure with no arguments was expected, suggest wrapping) - #53329 (Replace usages of ptr::offset with ptr::{add,sub}.) - #53363 (add individual docs to `core::num::NonZero*`) - #53370 (Stabilize macro_vis_matcher) - #53393 (Mark libserialize functions as inline) - #53405 (restore the page title after escaping out of a search) - #53452 (Change target triple used to check for lldb in build-manifest) - #53462 (Document Box::into_raw returns non-null ptr) - #53465 (Remove LinkMeta struct) - #53492 (update lld submodule to include RISCV patch) - #53496 (Fix typos found by codespell.) - #53521 (syntax: Optimize some literal parsing) - #53540 (Moved issue-53157.rs into src/test/ui/consts/const-eval/) - #53551 (Avoid some Place clones.) Failed merges: r? @ghost

@ghost

[beta] Rollup backports Merged and approved: * #53030: Updated RELEASES.md for 1.29.0 * #53594: Update RELEASES.md to include clippy-preview * #53045: Fix NLL migration mode so that reports region errors when necessary. * #53163: Remove an overly pedantic and wrong assertion r? @ghost

Updated RELEASES.md for 1.29.0

3350eaf

rust-highfive assigned Mark-Simulacrum Aug 3, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2018

est31 requested changes Aug 3, 2018

View reviewed changes

kennytm reviewed Aug 3, 2018

View reviewed changes

Aaronepower added 2 commits August 3, 2018 18:27

Update RELEASES.md

a646c10

Update RELEASES.md

96f50f1

Update RELEASES.md

b4924bf

sgrif reviewed Aug 4, 2018

View reviewed changes

TimNN added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2018

XAMPPRocky added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2018

Mark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 20, 2018

kennytm mentioned this pull request Aug 20, 2018

Rollup of 17 pull requests #53530

Merged

bors merged commit b4924bf into rust-lang:master Aug 21, 2018

emilyalbini added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 25, 2018

emilyalbini mentioned this pull request Aug 25, 2018

[beta] Rollup backports #53694

Merged

emilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 25, 2018

Uh oh!

Conversation

XAMPPRocky commented Aug 3, 2018

Uh oh!

phansch commented Aug 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kennytm Aug 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum commented Aug 3, 2018

Uh oh!

Havvy commented Aug 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sgrif Aug 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum commented Aug 20, 2018

Uh oh!

bors commented Aug 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

phansch commented Aug 3, 2018 •

edited

Loading

kennytm Aug 3, 2018 •

edited

Loading

Havvy commented Aug 3, 2018 •

edited

Loading

sgrif Aug 4, 2018 •

edited

Loading