remove let x = baz which was obscuring the real error#53129
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 31, 2018
Merged
remove let x = baz which was obscuring the real error#53129bors merged 1 commit intorust-lang:masterfrom
let x = baz which was obscuring the real error#53129bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
r? @pnkfelix |
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 2403d91 has been approved by |
bors
added
S-waiting-on-bors
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
…, r=pnkfelix remove `let x = baz` which was obscuring the real error fixes rust-lang#51172
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
…, r=pnkfelix remove `let x = baz` which was obscuring the real error fixes rust-lang#51172
This was referenced Aug 8, 2018
Member
|
I'm not sure if there's another commit in the queue which changes the error message here, but this has caused failures in rollups a couple of times: see #53184 (comment) and #53195 (comment). |
Contributor
Author
|
I think it is probably because of one of the PRs from @davidtwco or @matthewjasper that change the error messages here. |
Member
|
@bors rollup- |
Collaborator
|
⌛ Testing commit 2403d91 with merge 10e06dad64cd7615f37891fbc65c3ab7082e46e8... |
Collaborator
|
💔 Test failed - status-appveyor |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-review
kennytm
added
S-waiting-on-author
Member
|
Ping from triage @nikomatsakis! It's been a while since we heard from you, will you have time to work on this again? |
nikomatsakis
force-pushed
the
issue-51172-tweak-test
branch
from
2403d91 to
f77ad5c
Compare
Contributor
Author
|
@bors r=pnkfelix rollup |
Collaborator
|
📌 Commit f77ad5c has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 28, 2018
…, r=pnkfelix remove `let x = baz` which was obscuring the real error fixes rust-lang#51172
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 28, 2018
…, r=pnkfelix remove `let x = baz` which was obscuring the real error fixes rust-lang#51172
emilyalbini
added a commit
to emilyalbini/rust
that referenced
this pull request
Aug 29, 2018
…, r=pnkfelix remove `let x = baz` which was obscuring the real error fixes rust-lang#51172
emilyalbini
added a commit
to emilyalbini/rust
that referenced
this pull request
Aug 29, 2018
…, r=pnkfelix remove `let x = baz` which was obscuring the real error fixes rust-lang#51172
emilyalbini
added a commit
to emilyalbini/rust
that referenced
this pull request
Aug 30, 2018
…, r=pnkfelix remove `let x = baz` which was obscuring the real error fixes rust-lang#51172
bors
added a commit
that referenced
this pull request
Aug 31, 2018
Rollup of 20 pull requests Successful merges: - #51760 (Add another PartialEq example) - #53113 (Add example for Cow) - #53129 (remove `let x = baz` which was obscuring the real error) - #53389 (document effect of join on memory ordering) - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.) - #53476 (Add partialeq implementation for TryFromIntError type) - #53513 (Force-inline `shallow_resolve` at its hottest call site.) - #53655 (set applicability) - #53702 (Fix stabilisation version for macro_vis_matcher.) - #53727 (Do not suggest dereferencing in macro) - #53732 (save-analysis: Differentiate foreign functions and statics.) - #53740 (add llvm-readobj to llvm-tools-preview) - #53743 (fix a typo: taget_env -> target_env) - #53747 (Rustdoc fixes) - #53753 (expand keep-stage --help text) - #53756 (Fix typo in comment) - #53768 (move file-extension based .gitignore down to src/) - #53785 (Fix a comment in src/libcore/slice/mod.rs) - #53786 (Replace usages of 'bad_style' with 'nonstandard_style'.) - #53806 (Fix UI issues on Implementations on Foreign types) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #51172