resolve: Do not error on access to proc macros imported with #[macro_use]#53461
resolve: Do not error on access to proc macros imported with #[macro_use]#53461bors merged 1 commit intorust-lang:masterfrom
#[macro_use]#53461Conversation
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
While this seems plausible to me, I'd defer to @rust-lang/lang in this regard as it's moreso a language change they'd likely wish to discuss. Folks on @rust-lang/lang, how do you feel about |
|
Given that we're moving towards using |
|
Given that |
|
@petrochenkov Fair enough. Sounds reasonable to me. |
|
I also think it sounds reasonable :) @rfcbot fcp merge |
|
Team member @Centril has proposed to merge this. The next step is review by the rest of the tagged teams:
No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
☔ The latest upstream changes (presumably #53471) made this pull request unmergeable. Please resolve the merge conflicts. |
emilyalbini
added
S-waiting-on-team
and removed
S-waiting-on-review
|
If this is just allowing the compiler to delete code, not changing idioms, @rfcbot reviewed |
rfcbot
added
proposed-final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
added
final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
rfcbot
added
finished-final-comment-period
|
Yay, FCP complete. |
|
📌 Commit e411bb3 has been approved by |
bors
added
S-waiting-on-bors
resolve: Do not error on access to proc macros imported with `#[macro_use]` This error is artificial, but previously, when `#[macro_use] extern crate x;` was stable, but non-derive proc macros were not, it worked like kind of a feature gate. Now both features are stable, so the error is no longer necessary. This PR simplifies how `#[macro_use] extern crate x;` works - it takes all items from macro namespace of `x`'s root and puts them into macro prelude from which they all can now be accessed.
|
☀️ Test successful - status-appveyor, status-travis |
10 participants
This error is artificial, but previously, when
#[macro_use] extern crate x;was stable, but non-derive proc macros were not, it worked like kind of a feature gate. Now both features are stable, so the error is no longer necessary.This PR simplifies how
#[macro_use] extern crate x;works - it takes all items from macro namespace ofx's root and puts them into macro prelude from which they all can now be accessed.