Revert most of MaybeUninit, except for the new API itself#54554
Revert most of MaybeUninit, except for the new API itself#54554bors merged 2 commits intorust-lang:masterfrom
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@rust-lang/wg-compiler-performance I'd prefer to also include 96572cb but wasn't sure if you'd be happy with that. |
|
Do we know why the regression occurred? |
|
@nagisa No. Don't have time to do any research right now, I am on a conference. But my preliminary plan was to then re-submit "half" of the remaining commits and see if perf complains, etc. My guess is that it's the |
|
@bors r+ |
|
📌 Commit b595e4f82377bb2c50201b3fc8b1f528cdc49b93 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #54575) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
@RalfJung this wants a rebase. |
|
I am on a conference, not sure if I can get to this before the weekend. Anyone, feel free to take over.
|
RalfJung
force-pushed
the
maybe-uninit
branch
from
b595e4f to
546e45a
Compare
|
Rebase done. @bors r=nagisa |
|
📌 Commit 546e45a has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=15 rollup fairness |
Revert most of MaybeUninit, except for the new API itself This reverts most of #53508 for perf reasons (first commit reverts that entire PR), except for the new API itself (added back in 2nd commit).
|
☀️ Test successful - status-appveyor, status-travis |
|
The final perf improvements from this landing are here. |
9 participants
This reverts most of #53508 for perf reasons (first commit reverts that entire PR), except for the new API itself (added back in 2nd commit).