std: Don't let rust_panic get inlined#54590
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 29, 2018
Merged
Conversation
It's meant for breakpoints, so if it gets inlined we can't set a breakpoint on it easily!
Contributor
|
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
dtolnay
approved these changes
Sep 26, 2018
Member
|
@bors r+ |
Collaborator
|
📌 Commit 243030b has been approved by |
Collaborator
|
⌛ Testing commit 243030b with merge 02c2f0d54d78d591237e14ecde03aa51a28adfef... |
Collaborator
|
💔 Test failed - status-travis |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Member
Author
|
@bors: retry |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Sep 29, 2018
…c, r=dtolnay std: Don't let `rust_panic` get inlined It's meant for breakpoints, so if it gets inlined we can't set a breakpoint on it easily! Will hopefully help fix at least one aspect of rust-lang#49013
bors
added a commit
that referenced
this pull request
Sep 29, 2018
Rollup of 8 pull requests Successful merges: - #54564 (Add 1.29.1 release notes) - #54567 (Include path in stamp hash for debuginfo tests) - #54577 (rustdoc: give proc-macros their own pages) - #54590 (std: Don't let `rust_panic` get inlined) - #54598 (Remove useless lifetimes from `Pin` `impl`s.) - #54604 (Added help message for `self_in_typedefs` feature gate) - #54635 (Improve docs for std::io::Seek) - #54645 (Compute Android gdb version in compiletest)
Collaborator
Member
|
@bors retry r- Wrongly rescheduled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's meant for breakpoints, so if it gets inlined we can't set a
breakpoint on it easily!
Will hopefully help fix at least one aspect of #49013