do not normalize non-scalar constants to a ConstValue::ScalarPair#54759
Closed
RalfJung wants to merge 1 commit intorust-lang:betafrom
Closed
do not normalize non-scalar constants to a ConstValue::ScalarPair#54759RalfJung wants to merge 1 commit intorust-lang:betafrom
RalfJung wants to merge 1 commit intorust-lang:betafrom
Conversation
Contributor
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
rust-highfive
added
the
S-waiting-on-review
RalfJung
added
beta-nominated
This was referenced Oct 2, 2018
emilyalbini
added
S-blocked
Contributor
|
discussed at compiler team meeting. Accepted for beta backport |
pnkfelix
added
beta-nominated
emilyalbini
removed
the
beta-nominated
Member
|
Rolled this up in #54821. |
bors
added a commit
that referenced
this pull request
Oct 4, 2018
[beta] Rollup backports Merged and approved: * #54605: resolve: Disambiguate a subset of conflicts "macro_rules" vs "macro name in module" * #54557: incr.comp.: Don't automatically enable -Zshare-generics for incr. comp. builds. * #54759: do not normalize non-scalar constants to a ConstValue::ScalarPair Closes #54759 r? @ghost
Member
|
This was backported in #54821. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #54693, avoiding changing
ConstValueto keep the churn down.Fixes #54387