Merged
Conversation
Contributor
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 37cc3a642c9e48d3bd772520b4ef2b0556f8c2e6 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #54592) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
ljedrz
force-pushed
the
cleanup_rustc_session
branch
from
37cc3a6 to
1b7de54
Compare
Contributor
Author
|
Rebased. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 1b7de54c4c1e47eaf31145afd1decd70bf8f768d has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #55008) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
ljedrz
force-pushed
the
cleanup_rustc_session
branch
from
1b7de54 to
42ae9dc
Compare
Contributor
Author
|
Rebased. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 42ae9dc has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 15, 2018
Cleanup rustc/session - improve allocations - improve common patterns - use `to_owned` when no string conversion is needed - move `const`s up to improve readability - whitespace & formatting improvements
bors
added a commit
that referenced
this pull request
Oct 15, 2018
Rollup of 11 pull requests Successful merges: - #54820 (Closes #54538: `unused_patterns` lint) - #54963 (Cleanup rustc/session) - #54991 (add test for #23189) - #55025 (Add missing lifetime fragment specifier to error message.) - #55047 (doc: make core::fmt::Error example more simple) - #55048 (Don't collect to vectors where unnecessary) - #55060 (clarify pointer add/sub function safety concerns) - #55062 (Make EvalContext::step public again) - #55066 (Fix incorrect link in println! documentation) - #55081 (Deduplicate tests) - #55088 (Update rustc documentation link) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_ownedwhen no string conversion is neededconsts up to improve readability