Help suggests non-existent package std::os::ext::process::CommandExt#55007

davidtwco · 2018-10-12T11:51:08Z

Fixes #39175.

rust-highfive · 2018-10-12T11:51:18Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

nikomatsakis · 2018-10-16T15:17:26Z

r? @petrochenkov

Glad to see this getting fixed, @davidtwco =)

src/librustc/ty/item_path.rs

petrochenkov · 2018-10-17T17:16:33Z

@bors r+

bors · 2018-10-17T17:16:34Z

📌 Commit e95472b has been approved by petrochenkov

Help suggests non-existent package std::os::ext::process::CommandExt Fixes rust-lang#39175.

davidtwco · 2018-10-19T10:49:41Z

Updated the test to only run on unix - this change isn't platform dependent so I think it's fine to not have a corresponding test for a Windows-only extension trait.

@bors r=petrochenkov

In order to output a path that could actually be imported (valid and visible), we need to handle re-exports correctly. For example, take `std::os::unix::process::CommandExt`, this trait is actually defined at `std::sys::unix::ext::process::CommandExt` (at time of writing). `std::os::unix` rexports the contents of `std::sys::unix::ext`. `std::sys` is private so the "true" path to `CommandExt` isn't accessible. In this case, the visible parent map will look something like this: (child) -> (parent) `std::sys::unix::ext::process::CommandExt` -> `std::sys::unix::ext::process` `std::sys::unix::ext::process` -> `std::sys::unix::ext` `std::sys::unix::ext` -> `std::os` This is correct, as the visible parent of `std::sys::unix::ext` is in fact `std::os`. When printing the path to `CommandExt` and looking at the current segment that corresponds to `std::sys::unix::ext`, we would normally print `ext` and then go to the parent - resulting in a mangled path like `std::os::ext::process::CommandExt`. Instead, we must detect that there was a re-export and instead print `unix` (which is the name `std::sys::unix::ext` was re-exported as in `std::os`).

davidtwco · 2018-10-19T13:47:31Z

Updated the test again so it only runs on platforms that other tests using CommandExt run on.

@bors r=petrochenkov

bors · 2018-10-19T13:47:32Z

📌 Commit 4334aaa has been approved by petrochenkov

davidtwco · 2018-10-19T20:23:04Z

@bors retry

bors · 2018-10-20T01:31:17Z

⌛ Testing commit 4334aaa with merge 89be71a...

Help suggests non-existent package std::os::ext::process::CommandExt Fixes #39175.

bors · 2018-10-20T04:11:33Z

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 89be71a to master...

This commit extends previous work in rust-lang#55007 where the name from the visible parent was used for modules. Now, we also print the name from the visible parent for types.

@estebank

Print visible name for types as well as modules. Fixes rust-lang#56943 and fixes rust-lang#57713. This commit extends previous work in rust-lang#55007 where the name from the visible parent was used for modules. Now, we also print the name from the visible parent for types. r? @estebank

This commit extends previous work in rust-lang#55007 where the name from the visible parent was used for modules. Now, we also print the name from the visible parent for types.

rust-highfive assigned nikomatsakis Oct 12, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2018

rust-highfive assigned petrochenkov and unassigned nikomatsakis Oct 16, 2018

petrochenkov reviewed Oct 17, 2018

View reviewed changes

src/librustc/ty/item_path.rs Outdated Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2018

kennytm added a commit to kennytm/rust that referenced this pull request Oct 18, 2018

Rollup merge of rust-lang#55007 - davidtwco:issue-39175, r=petrochenkov

311fd3c

Help suggests non-existent package std::os::ext::process::CommandExt Fixes rust-lang#39175.

kennytm mentioned this pull request Oct 18, 2018

Rollup of 9 pull requests #55181

Closed

kennytm mentioned this pull request Oct 19, 2018

Rollup of 7 pull requests #55194

Merged