[NLL] Propagate bounds from generators#55013

matthewjasper · 2018-10-12T14:17:47Z

This used to only be done for closures.

r? @nikomatsakis

nikomatsakis · 2018-10-16T15:16:06Z

@bors r+

bors · 2018-10-16T15:16:07Z

📌 Commit 4627eb9d55710b09e8a2f24888dd8d7e3ea27270 has been approved by nikomatsakis

nikomatsakis · 2018-10-16T15:16:11Z

Good catch.

bors · 2018-10-17T02:04:01Z

☔ The latest upstream changes (presumably #55093) made this pull request unmergeable. Please resolve the merge conflicts.

matthewjasper · 2018-10-17T19:31:07Z

@bors r=nikomatsakis

bors · 2018-10-17T19:31:08Z

📌 Commit b95f7dbcdcfbae7abe1c060bf8839254e3438e26 has been approved by nikomatsakis

matthewjasper · 2018-10-18T21:48:54Z

@bors r=nikomatsakis

bors · 2018-10-18T21:48:55Z

📌 Commit ef1a40d has been approved by nikomatsakis

bors · 2018-10-19T04:51:23Z

⌛ Testing commit ef1a40d with merge 5906face9984dcab3528d430193b6d3247749ab3...

bors · 2018-10-19T06:38:07Z

💔 Test failed - status-travis

rust-highfive · 2018-10-19T06:38:08Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:16fc9ee4:start=1539931080547300831,finish=1539931080554698599,duration=7397768
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0c551f48
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0e3bebbe
travis_time:start:0e3bebbe
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0d2b7bf0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-10-19T08:41:57Z

@bors retry travis-ci/travis-ci#9696

…ounds, r=nikomatsakis [NLL] Propagate bounds from generators This used to only be done for closures.

Rollup of 7 pull requests Successful merges: - #54300 (Updated RELEASES.md for 1.30.0) - #55013 ([NLL] Propagate bounds from generators) - #55071 (Fix ICE and report a human readable error) - #55144 (Cleanup resolve) - #55166 (Don't warn about parentheses on `match (return)`) - #55169 (Add a `copysign` function to f32 and f64) - #55178 (Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut())

rust-highfive assigned nikomatsakis Oct 12, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2018

memoryruins added the A-NLL Area: Non-lexical lifetimes (NLL) label Oct 12, 2018

matthewjasper force-pushed the propagate-generator-bounds branch from 5bb5e2c to 4627eb9 Compare October 13, 2018 09:13

nikomatsakis approved these changes Oct 16, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 17, 2018

matthewjasper force-pushed the propagate-generator-bounds branch from 4627eb9 to b95f7db Compare October 17, 2018 19:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 17, 2018

kennytm mentioned this pull request Oct 18, 2018

Rollup of 9 pull requests #55181

Closed

Propagate bounds from generators

ef1a40d

matthewjasper force-pushed the propagate-generator-bounds branch from b95f7db to ef1a40d Compare October 18, 2018 21:48

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 19, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2018

kennytm added a commit to kennytm/rust that referenced this pull request Oct 19, 2018

Rollup merge of rust-lang#55013 - matthewjasper:propagate-generator-b…

0724efd

…ounds, r=nikomatsakis [NLL] Propagate bounds from generators This used to only be done for closures.

kennytm mentioned this pull request Oct 19, 2018

Rollup of 7 pull requests #55194

Merged

bors merged commit ef1a40d into rust-lang:master Oct 19, 2018

matthewjasper deleted the propagate-generator-bounds branch October 21, 2018 16:19

SimonSapin mentioned this pull request Oct 22, 2018

ICE 'allocation missing in dead_alloc_map' in rustc_mir::interpret when compiling Servo #55223

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[NLL] Propagate bounds from generators#55013